From: Andrew Gaylard <ag@ffroot.co.za>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Daniel Machon <daniel.machon@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Gaylard <ag@ffroot.co.za>
Subject: [PATCH net-next v2] net: sunplus: also fix the byte order of 1c:50:1e MAC addresses
Date: Fri, 20 Nov 2026 09:39:01 +0200 [thread overview]
Message-ID: <20261120073901.21656-1-ag@ffroot.co.za> (raw)
The driver reverses a MAC address from the OTP when it finds the
Sunplus OUI fc:4b:bc at the wrong end. Newer SP7021 chips have
a different Sunplus OUI (1c:50:1e), possibly stored in the same
reversed order, which the driver does not recognise. If the reversed
address has the multicast bit set, the driver rejects it and uses a
random address; otherwise it uses the reversed address as it is.
Handle both these OUIs. An address that already starts with either OUI
is left as is. On chips that used the reversed address, the interface
now gets the correct address, so configuration tied to the old address
(DHCP reservations, udev or networkd rules) will need updating.
Tested on chips that needed each of these OUIs to be reversed.
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>
---
v2: Use a helper that checks for both OUIs instead of an OUI table and
two loops, as suggested by Daniel Machon.
v1: https://lore.kernel.org/netdev/20261112123738.429728-1-ag@ffroot.co.za/
drivers/net/ethernet/sunplus/spl2sw_driver.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
index 9ccaf928ed66..b5ae950f6d5b 100644
--- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -203,15 +203,20 @@ static const struct net_device_ops netdev_ops = {
.ndo_tx_timeout = spl2sw_ethernet_tx_timeout,
};
+static bool spl2sw_is_sunplus_oui(u8 b0, u8 b1, u8 b2)
+{
+ return (b0 == 0xfc && b1 == 0x4b && b2 == 0xbc) ||
+ (b0 == 0x1c && b1 == 0x50 && b2 == 0x1e);
+}
+
static void spl2sw_check_mac_vendor_id_and_convert(u8 *mac_addr)
{
- /* Byte order of MAC address of some samples are reversed.
- * Check vendor id and convert byte order if it is wrong.
- * OUI of Sunplus: fc:4b:bc
+ /* Some chips have the byte order of the MAC address reversed.
+ * Check for the Sunplus OUIs (fc:4b:bc, 1c:50:1e) and fix the
+ * byte order if it is.
*/
- if (mac_addr[5] == 0xfc && mac_addr[4] == 0x4b && mac_addr[3] == 0xbc &&
- (mac_addr[0] != 0xfc || mac_addr[1] != 0x4b || mac_addr[2] != 0xbc)) {
-
+ if (spl2sw_is_sunplus_oui(mac_addr[5], mac_addr[4], mac_addr[3]) &&
+ !spl2sw_is_sunplus_oui(mac_addr[0], mac_addr[1], mac_addr[2])) {
swap(mac_addr[0], mac_addr[5]);
swap(mac_addr[1], mac_addr[4]);
swap(mac_addr[2], mac_addr[3]);
base-commit: 2208ab00f4f213ade91ab775e7f8c4dacdcc856e
--
2.53.0
reply other threads:[~2026-11-20 7:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120073901.21656-1-ag@ffroot.co.za \
--to=ag@ffroot.co.za \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox