Netdev List
 help / color / mirror / Atom feed
From: Lin Lei <llleigoing@gmail.com>
To: matttbe@kernel.org
Cc: edumazet@kernel.org, llleigoing@outlook.com,
	netdev@vger.kernel.org, mptcp@lists.linux.dev,
	ncardwell@google.com, kuniyu@google.com, davem@davemloft.net,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	martineau@kernel.org, geliang@kernel.org
Subject: Re: [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning
Date: Fri, 20 Nov 2026 08:05:58 +0000	[thread overview]
Message-ID: <20261120080558.2866468-1-llleigoing@gmail.com> (raw)
In-Reply-To: <cab39a1c-056f-488f-b217-194af2056db2@kernel.org>

Hi Matthieu and Eric,

> It looks good to me too, please send a v2 with the Signed-off-by:

Thanks for the reviews. I sent the fix as a standalone v2 with my
corrected sign-off and both of your Reviewed-by tags:

https://lore.kernel.org/all/20261120075459.2862977-1-llleigoing@gmail.com/

> @Lei: could you open a PR on this separate repository with a new test,
> please?

Thanks for the script, Matthieu. I used it as the basis for the test
and opened the PR here:

https://github.com/multipath-tcp/packetdrill/pull/214

I ran the test three times each on IPv4, IPv6 and IPv4-mapped IPv6.
Before the fix, SO_RCVBUF grew from 8192 to 50237 bytes in all nine
runs. With the fix, it stayed at 8192 bytes in all nine.

Thanks,
Lin

  reply	other threads:[~2026-11-20  8:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-19  7:54   ` Eric Dumazet
2026-11-20  8:22   ` netdev-bot+sashiko
2026-11-17  5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-19  7:56   ` Eric Dumazet
2026-11-20  8:22   ` netdev-bot+sashiko
2026-11-17  5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-19  7:59   ` Eric Dumazet
2026-11-19 18:33     ` Matthieu Baerts
2026-11-20  8:05       ` Lin Lei [this message]
2026-11-20  8:22   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120080558.2866468-1-llleigoing@gmail.com \
    --to=llleigoing@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=llleigoing@outlook.com \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox