From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: netdev@vger.kernel.org, "(JC),
Jayachandran" <j-rameshbabu@ti.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Chintan Vankar <c-vankar@ti.com>,
Danish Anwar <danishanwar@ti.com>, Daolin Qiu <d-qiu@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Felix Maurer <fmaurer@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Neelima Muralidharan <neelima@ti.com>,
Paolo Abeni <pabeni@redhat.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Pratheesh Gangadhar TK <pratheesh@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Eric Dumazet <edumazet@kernel.org>
Subject: Re: [PATCH net-next v10 5/8] hsr: Use the port and header information in hsr_forward_skb()
Date: Fri, 20 Nov 2026 10:06:58 +0100 [thread overview]
Message-ID: <20261120090658.6rZGUWMm@linutronix.de> (raw)
In-Reply-To: <20261110132337.2h42rt4xh5h4dc3x@DEN-DL-M70577>
On 2026-11-10 14:23:37 [+0100], Daniel Machon wrote:
> Hi Sebastian,
Hi Daniel,
> > --- a/net/hsr/hsr_forward.c
> > +++ b/net/hsr/hsr_forward.c
> > @@ -570,6 +571,19 @@ static void hsr_forward_do(struct hsr_frame_info *frame)
> > if ((port->dev->features & NETIF_F_HW_HSR_DUP) && sent)
> > continue;
> >
> > + /* If this frame has a specific outgoing port specified (by the
> > + * sender) then send it on this port only.
> > + */
> > + if (frame->req_tx_port != HSR_PT_NONE && frame->req_tx_port != port->type)
> > + continue;
>
> This could easily be wrapped at 80 to avoid the warning.
okay. I'm going to keep sneaky clean up and avoid the two 80s warnings.
> /Daniel
Sebastian
next prev parent reply other threads:[~2026-11-20 9:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:10 [PATCH net-next v10 0/8] hsr: Allow to send packets on specific port and pass the timestamp Sebastian Andrzej Siewior
2026-11-04 15:10 ` [PATCH net-next v10 1/8] hsr: Add header_ops::parse_protocol Sebastian Andrzej Siewior
2026-11-10 12:21 ` Daniel Machon
2026-11-04 15:10 ` [PATCH net-next v10 2/8] hsr: Use skb_clone() while adding the HSR header Sebastian Andrzej Siewior
2026-11-10 12:24 ` Daniel Machon
2026-11-04 15:10 ` [PATCH net-next v10 3/8] hsr: Add a magic header for sending PTP packets Sebastian Andrzej Siewior
2026-11-10 13:12 ` Daniel Machon
2026-11-20 8:55 ` Sebastian Andrzej Siewior
2026-11-04 15:10 ` [PATCH net-next v10 4/8] hsr: Drop received " Sebastian Andrzej Siewior
2026-11-10 13:13 ` Daniel Machon
2026-11-04 15:10 ` [PATCH net-next v10 5/8] hsr: Use the port and header information in hsr_forward_skb() Sebastian Andrzej Siewior
2026-11-10 13:23 ` Daniel Machon
2026-11-20 9:06 ` Sebastian Andrzej Siewior [this message]
2026-11-04 15:10 ` [PATCH net-next v10 6/8] hsr: Assign a socket for cloned skbs Sebastian Andrzej Siewior
2026-11-10 13:24 ` Daniel Machon
2026-11-04 15:10 ` [PATCH net-next v10 7/8] hsr: Move struct hsr_ethhdr to a global header Sebastian Andrzej Siewior
2026-11-10 13:24 ` Daniel Machon
2026-11-04 15:10 ` [PATCH net-next v10 8/8] selftests: hsr: Add test for the inline PTP header on HSR Sebastian Andrzej Siewior
2026-11-10 13:48 ` [PATCH net-next v10 0/8] hsr: Allow to send packets on specific port and pass the timestamp Daniel Machon
2026-11-20 7:47 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120090658.6rZGUWMm@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=c-vankar@ti.com \
--cc=d-qiu@ti.com \
--cc=daniel.machon@microchip.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=j-rameshbabu@ti.com \
--cc=kuba@kernel.org \
--cc=neelima@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=vigneshr@ti.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox