From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Russell King" <linux@armlinux.org.uk>,
"Lorenzo Bianconi" <lorenzo.bianconi@oss.qualcomm.com>,
"Nicolai Buchwitz" <nb@tipi-net.de>,
"Ovidiu Panait" <ovidiu.panait.rb@renesas.com>,
"Joseph Steel" <recv.jo@gmail.com>,
"Muhammad Nazim Amirul Nazle Asmade"
<muhammad.nazim.amirul.nazle.asmade@altera.com>,
thomas.petazzoni@bootlin.com,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: stmmac: xgmac: Report the VLAN tag type from the descriptor
Date: Fri, 20 Nov 2026 16:46:01 -0800 [thread overview]
Message-ID: <20261120164601.07f932cd@kernel.org> (raw)
In-Reply-To: <20261118162136.2782405-1-maxime.chevallier@bootlin.com>
On Wed, 18 Nov 2026 17:21:34 +0100 Maxime Chevallier wrote:
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c
> @@ -209,8 +209,12 @@ static void vlan_rx_hw(struct mac_device_info *hw,
> {
> if (hw->desc->get_rx_vlan_valid(rx_desc)) {
> u16 vid = hw->desc->get_rx_vlan_tci(rx_desc);
> + u16 proto = ETH_P_8021Q;
>
> - __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vid);
> + if (hw->desc->get_rx_vlan_proto)
> + proto = hw->desc->get_rx_vlan_proto(rx_desc);
> +
> + __vlan_hwaccel_put_tag(skb, htons(proto), vid);
Heh, this function now does 3 indirect calls to get the info about
the stripped vlan. Isn't this slower than disabling the offload and
stripping in SW at this point? Maybe the low-end CPUs are very
different :) Or there's something else I'm missing?
(not really expecting you to do any digging, to be clear, just found
the level of complexity in SW to support a trivial HW offload kinda
funny)
next prev parent reply other threads:[~2026-11-21 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 16:21 [PATCH net-next] net: stmmac: xgmac: Report the VLAN tag type from the descriptor Maxime Chevallier
2026-11-18 20:09 ` Nicolai Buchwitz
2026-11-19 7:36 ` Maxime Chevallier
2026-11-20 17:13 ` Muhammad Nazim Amirul Nazle Asmade
2026-11-19 17:09 ` netdev-bot+sashiko
2026-11-20 10:22 ` Maxime Chevallier
2026-11-21 0:46 ` Jakub Kicinski [this message]
2026-11-21 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120164601.07f932cd@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=recv.jo@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox