From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795224253; b=S6K39e9/qwMa2gdHilBgWbRBM4ct/L70rC6yhokr9Y9bxJM47U8jfAdRpoBgHyZbLI9I z8lFqFMbNprWb/1FaDiIvdK8IcBrjCmk5/oEw7aQZt1ab5fUa/Sb6cEveKG0xBcs2bGNa YNYhM/5NuXqEGC7BCC4wMUT/BJmSHQ/Aoh1JpJmOO6vqFNe6oTLExChskr2kV2eGjyybC OgGR5tBCCxR8GoZHv3oCxPmgkAqlm8huWt7/C5h3t7N2Di/mnOq8j2C1e2inwNB8PBFTf +rg+nDiwrxpEFJ3o0yMXoxE7wKX01Eyo3GJ3AKzp6QjjsFy//79ez6LBXIzCiYNQ0zg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795224253; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=CgSRkrT3C0ViBLHE9DlJxbToE1aRxdogX3+8Kv7zlYY=; b=hGh+aTsMSHzGqAJ7R2ECkx5AUoK0+1NEQZN2QmKBnFUIplhV2HmgHYtsKC47C4XpNL8o NKajx6owYAoS5+i/6XYpnf4RmYq+NZfRlpFJ55SKgWDbcj0wpGa8dkyjbak0mz5KvlNKH 0J3ukSPAg9tqy8L0NNut4rK8nLJRrS/SBbuE3rzohvcF9eoxBpNxflDNxqHGFZXAbhchM +1VjPvpZUnRwJ3Q807clZ63Sl1sRtvtpnN1OovixfvuWQpF35BwknDTqHy7aTB8WVXJMY DiTxdzOLJ5YRkyX4uKJOnbCI+SDa2px+kgnuvijKLASWqGlHfjUUcjQcOp63zzyaIew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=QTgeak9m; arc=none smtp.remote-ip=209.85.218.52 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5FA4606A68F for ; Sat, 21 Nov 2026 01:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E5FA4606A68F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=QTgeak9m Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c50cc8e0f84so238786266b.1 for ; Fri, 20 Nov 2026 17:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1795224247; x=1795829047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=CgSRkrT3C0ViBLHE9DlJxbToE1aRxdogX3+8Kv7zlYY=; b=QTgeak9mIs1Z8LVAaKgxdPGIhe77qyXmkMZCK4Wshq4NMtZVSLO6R8rxQwUG7Q2w/n C1xC+tnusGY7NKssSWETx78hJWC79i1zwyoWNb6kHGOQvx9t4M/nGuwb3JAOE03ZKiNf iLAGdxwXD1BhXDQbhJFeFwrB1+NMibLxhZ9xUqliWXDRCjGyZgIGUfb2F1S3GP00NdV0 bxGILYSTRRgko/IBHMchgMsG8nvuVMRIqNSkYOLZvBf+hT0nIxdKdDRKaEuXJcrO/sol 9hRVVkREtwFLhwURR9DnI1gq99ih5p6ByOY6ffTsPu4OfSiFcK5FH9mr1K+0znwZ4dVE AuIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795224247; x=1795829047; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CgSRkrT3C0ViBLHE9DlJxbToE1aRxdogX3+8Kv7zlYY=; b=rOUs3eG3uzmYU7t43tsXaKSVklGgAOWez+g3Yu9HaKykw6SrqzHMw8SkBLW+km5eYK MMGw5B79KmVDWFoVJjjpCIgAk9XSIMpgSWxAcfqq9STXGcSapoyhOeLd/MSydCOorSsJ njefNBan8AunXq36lttE0XXznrOg1w+ZKcd2h+IbvjOOMAC2/CLTYb8GJaRTjHHrk1yu A8aNJ8BSbrMH/ZAEkWjc2mSeYVD4YtMCdlitN3j2ekJ9mZ9H645LmQdqV7EYnzJ1wMi4 QmfO0EurCvUFOvO/XmevzSB6lrlkIYoH+qicn37lWeOyXgnxlhfhttwbI/Z7lVhP8ZpJ tbOA== X-Gm-Message-State: APuU4Z8BMNgmzvIEchHwZUCOSiF+IJ+zE/ZPipXZEjxAkSSlFpODGaWv 5yIS4wZZO/AgzwFtL6TcH0orUP2excZEdGwBx8YflmKqQsm1Lh+RmNQbv0jn5qEKcDaAAxPrKgo UqDpzqDUAGA== X-Gm-Gg: AYBFou3h30Q2563P/k0ietq42IkpkZCmVIhc8b+bMeBqY4GuM0129L1weHI4jlseb4i br37oYY4/JV5j/2wwempFOH5Ae6TDBm+7wtaGRxn3x3pS/oidxugvAauNHZfRPs80Vkda9VFtdf UuqEwdCCSeT88L84EoHUQSvP4OqxwgQLuo07TWoIaO70ZYJln7riov0gX+3byWj4lIKn6u6FzTb GyQbPQBv94SezSmxKbZ5e57Yp0Qskja+kYlw6twHR9Tmu3IWXhjx4yPz7DCMql+D0+tKTlmlbPW E1FNxzGNQYXebvXo+DJ0+CQWWld4ErMttdCdg/va8uSwlsl3HyH5MLjXSO/JmRWDOJSYlnF/YWi vKfwrsYeyJiQicX3znkSdHxkk2kF1d6+7XAeLaVMOOkFCfYUc8Q9sHgu1cExggK598OOHJVs653 cDfCQIfCaT7AqkH/GnrfP8cp4tX2ddLlS8PLkRJV1D3k2DQMEMVKhhT+cYU/g4Gt1z2QKOjRGB3 Dx33EBJX9ShZU6lBR3BuMyp1uVR5V79Z+k4UcUawkh7BCrrnsfbLJ8HyiQS4sheLOWx+nXTEiei TqJ1bk+/OVCzS+FFJaUVOFXjyktqN3GEEJZNKTK5yj++KGTC1It9eRzXug== X-Received: by 2002:a17:906:7944:b0:c50:564b:c63 with SMTP id a640c23a62f3a-c513a43559cmr500636266b.6.1795224246891; Fri, 20 Nov 2026 17:24:06 -0800 (PST) Received: from L9JK9NPFH9 ([104.28.20.56]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c513ae6872asm143855266b.13.2026.11.20.17.24.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Nov 2026 17:24:05 -0800 (PST) From: Tianyi Gao To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Tony Nguyen , Przemek Kitszel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Paul Greenwalt , Alice Michael , Eric Joyner , Jesse Brandeburg , Lorenzo Bianconi , bpf@vger.kernel.org, kernel-team@cloudflare.com, tianyi.gao@linux.dev, Tianyi Gao Subject: [PATCH net] ice: do not report CHECKSUM_COMPLETE when an XDP program is attached Date: Sat, 21 Nov 2026 01:24:02 +0000 Message-ID: <20261121012402.84848-1-tianyi@cloudflare.com> X-Mailer: git-send-email 2.56.0 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On E830, ice reports CHECKSUM_COMPLETE with the generic checksum (GCS) that the hardware computes over the received frame. If an XDP program changes the packet and returns XDP_PASS, that checksum no longer matches. The stack then checks the packet again in software and calls netdev_rx_csum_fault(). On Cloudflare servers, an XDP load balancer removes the encapsulation of the packets that it accepts locally. Our production traffic hits netdev_rx_csum_fault() all the time. Do not use GCS when the ring has an XDP program, as mlx5 has done since commit 5d0bb3bac4b9 ("net/mlx5e: XDP, Avoid checksum complete when XDP prog is loaded"). E830 also sets the L3L4P and checksum error bits, so the packet gets CHECKSUM_UNNECESSARY or CHECKSUM_NONE, as on E810. For example, a zero UDP checksum over IPv6 is marked as bad and gets CHECKSUM_NONE. A zero UDP checksum over IPv4 gets CHECKSUM_UNNECESSARY. Two pending series [1][2] give XDP access to the checksum status. Neither of them supports CHECKSUM_COMPLETE. ice_rx_csum() reads rx_ring->xdp_prog again after the poll loop ran XDP. While ICE_VSI_REBUILD_PENDING is set, ice_xdp_setup_prog() can replace the program without stopping NAPI, so the two reads can differ. At worst, a packet in that poll gets CHECKSUM_COMPLETE as before this patch. The pointer is only compared with NULL, so this cannot crash. Link: https://lore.kernel.org/all/20260715-bpf-xdp-meta-rxcksum-v5-0-623d5c0d0ab7@kernel.org/ [1] Link: https://lore.kernel.org/all/cover.1794281983.git.tianyi@cloudflare.com/ [2] Fixes: 905d1a220e8d ("ice: Add E830 checksum offload support") Suggested-by: Jesse Brandeburg Signed-off-by: Tianyi Gao --- Tested on an E830 (8086:12d2, board N31483-007, fw.mgmt 7.9.5, DDP ICE COMMS 1.3.63.0) with an XDP program that removes a UDP encapsulation header with bpf_xdp_adjust_head() and returns XDP_PASS. The kernel was based on 6.18.64, where ice_rx_csum() is the same as in net: - Before: 63322069 netdev_rx_csum_fault() calls in 30 s. - After: 0. - Without an XDP program, the port still reports CHECKSUM_COMPLETE. On an E810, which has no GCS, drivers/net/xdp.py, ping.py and hw/csum.py give the same results with and without this patch. Request for comment: I also prepared a drv-net selftest for net-next. It removes 16 bytes from the UDP payload with bpf_xdp_adjust_head() and fails if the packet reaches the stack with CHECKSUM_COMPLETE. I am not sure we want to enforce this for all NICs, so asking here. drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c index e695a664e53d..ad22d855436e 100644 --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c @@ -123,6 +123,7 @@ ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, rx_status1 = le16_to_cpu(rx_desc->wb.status_error1); if ((ring->flags & ICE_RX_FLAGS_RING_GCS) && + !READ_ONCE(ring->xdp_prog) && rx_desc->wb.rxdid == ICE_RXDID_FLEX_NIC && (decoded.inner_prot == LIBETH_RX_PT_INNER_TCP || decoded.inner_prot == LIBETH_RX_PT_INNER_UDP || base-commit: 92e97d7cffc7ec6adfa4699203c18b1ab0c8b314 -- 2.56.0