From: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: "Alexander Duyck" <alexanderduyck@fb.com>,
"Jakub Kicinski" <kuba@kernel.org>,
kernel-team@meta.com, "Andrew Lunn" <andrew+netdev@lunn.ch>,
"Eric Dumazet" <edumazet@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Willem de Bruijn" <willemb@google.com>,
"Simon Horman" <horms@kernel.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Bobby Eshleman" <bobbyeshleman@meta.com>,
"Mina Almasry" <almasrymina@google.com>,
"Dimitri Daskalakis" <daskald@meta.com>,
netdev@vger.kernel.org,
"Dimitri Daskalakis" <dimitri.daskalakis1@gmail.com>
Subject: [PATCH net 0/4] eth: fbnic: queue stop fixes
Date: Fri, 20 Nov 2026 19:32:11 -0800 [thread overview]
Message-ID: <20261121033215.1020506-1-dimitri.daskalakis1@gmail.com> (raw)
From: Dimitri Daskalakis <daskald@meta.com>
AI uncovered some pre-existing issues with fbnic's queue stop handling.
If the idle wait fails in fbnic_queue_stop(), queues can be reset with
in-flight DMAs and completions. fbnic_queue_stop() did not wait for in-flight
xmits to complete before tearing down queues. And fbnic_wait_queue_idle()
waited on the wrong idle bits for Tx queues.
Patches 1 and 3 were verified on HW, and patch 4 was verified in QEMU.
Dimitri Daskalakis (4):
eth: fbnic: restart queues in place when fbnic_queue_stop() fails
net: add netif_disable_subqueue()
eth: fbnic: wait for in-flight xmit in fbnic_queue_stop()
eth: fbnic: wait for both TWQs of a Tx queue to go idle
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 84 ++++++++++++++++----
include/linux/netdevice.h | 36 ++++++---
2 files changed, 91 insertions(+), 29 deletions(-)
--
2.52.1
next reply other threads:[~2026-11-21 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 3:32 Dimitri Daskalakis [this message]
2026-11-21 3:32 ` [PATCH net 1/4] eth: fbnic: restart queues in place when fbnic_queue_stop() fails Dimitri Daskalakis
2026-11-21 3:32 ` [PATCH net 2/4] net: add netif_disable_subqueue() Dimitri Daskalakis
2026-11-21 3:32 ` [PATCH net 3/4] eth: fbnic: wait for in-flight xmit in fbnic_queue_stop() Dimitri Daskalakis
2026-11-21 3:32 ` [PATCH net 4/4] eth: fbnic: wait for both TWQs of a Tx queue to go idle Dimitri Daskalakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121033215.1020506-1-dimitri.daskalakis1@gmail.com \
--to=dimitri.daskalakis1@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@kernel.org \
--cc=bobbyeshleman@meta.com \
--cc=daskald@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox