From: Yuyang Huang <yuyanghuang@google.com>
To: Yuyang Huang <yuyanghuang@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf.kernel@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH net-next] net: zero hw address entries on allocation
Date: Sun, 22 Nov 2026 09:26:33 +0900 [thread overview]
Message-ID: <20261122002633.584362-1-yuyanghuang@google.com> (raw)
__hw_addr_create() allocates struct netdev_hw_addr with kmalloc() and
copies only addr_len bytes into ha->addr[MAX_ADDR_LEN], leaving the
rest uninitialized.
If dev->addr_len later grows while entries remain (e.g., adding a
multicast address to a down TAP device with SIOCADDMULTI and then
switching it to ARPHRD_TUNNEL6 via TUNSETLINK), readers using
dev->addr_len such as /proc/net/dev_mcast and AF_PACKET
RTM_GETMULTICAST expose the uninitialized trailing slab bytes, and
__hw_addr_add_ex() reads them in memcmp().
Switch __hw_addr_create() to kzalloc() so the unused tail of ha->addr
is always zero.
Link: https://lore.kernel.org/netdev/179012275175.2160803.16091441325063775173@kernel.org/
Signed-off-by: Yuyang Huang <yuyanghuang@google.com>
---
net/core/dev_addr_lists.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
index b6f25e487984..ff0815d8f6a8 100644
--- a/net/core/dev_addr_lists.c
+++ b/net/core/dev_addr_lists.c
@@ -100,7 +100,7 @@ __hw_addr_create(const unsigned char *addr, int addr_len,
alloc_size = sizeof(*ha);
if (alloc_size < L1_CACHE_BYTES)
alloc_size = L1_CACHE_BYTES;
- ha = kmalloc(alloc_size, GFP_ATOMIC);
+ ha = kzalloc(alloc_size, GFP_ATOMIC);
if (!ha)
return NULL;
memcpy(ha->addr, addr, addr_len);
--
2.56.1.750.gf70dc682cf-goog
next reply other threads:[~2026-11-22 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 0:26 Yuyang Huang [this message]
2026-11-22 0:32 ` [PATCH net-next] net: zero hw address entries on allocation netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122002633.584362-1-yuyanghuang@google.com \
--to=yuyanghuang@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox