From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, willemb@google.com, horms@kernel.org,
razor@blackwall.org, dsahern@kernel.org, shuah@kernel.org,
bridge@lists.linux.dev, linux-kselftest@vger.kernel.org,
kyuwoncho18@gmail.com, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net 2/2] selftests: bridge_mdb: Test failed source list replace
Date: Sun, 22 Nov 2026 09:25:04 +0200 [thread overview]
Message-ID: <20261122072504.2623702-2-idosch@nvidia.com> (raw)
In-Reply-To: <20261122072504.2623702-1-idosch@nvidia.com>
Add a test case for the issues that were fixed in "bridge: mcast: Fix
source list rollback on failure". Check that a failed replace of a
(*, G) entry does not change its source list, with one of the existing
sources specified twice and a new source.
Output without the fix:
# ./bridge_mdb.sh
[...]
TEST: IPv4 (*, G) port group entries configuration tests [FAIL]
(S, G) entry for source 192.0.2.1 deleted after failed replace
TEST: IPv6 (*, G) port group entries configuration tests [FAIL]
(S, G) entry for source 2001:db8:1::1 deleted after failed replace
[...]
Output with the fix:
# ./bridge_mdb.sh
[...]
TEST: IPv4 (*, G) port group entries configuration tests [ OK ]
TEST: IPv6 (*, G) port group entries configuration tests [ OK ]
[...]
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
.../selftests/net/forwarding/bridge_mdb.sh | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
index e86d77946585..712b9a5a0e5f 100755
--- a/tools/testing/selftests/net/forwarding/bridge_mdb.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
@@ -293,6 +293,7 @@ __cfg_test_port_ip_star_g()
local grp=$1; shift
local invalid_grp=$1; shift
local src_prefix=$1; shift
+ local invalid_src=$1; shift
local src1=${src_prefix}1
local src2=${src_prefix}2
local src3=${src_prefix}3
@@ -487,6 +488,23 @@ __cfg_test_port_ip_star_g()
bridge mdb del dev br0 port $swp1 grp $grp vid 10
+ # Check that a failed replace does not change the source list.
+ bridge mdb add dev br0 port $swp1 grp $grp temp vid 10 \
+ filter_mode exclude source_list $src1,$src2
+
+ bridge mdb replace dev br0 port $swp1 grp $grp temp vid 10 \
+ filter_mode exclude source_list $src1,$src1,$src3,$invalid_src \
+ &> /dev/null
+ check_fail $? "Managed to replace source list with an invalid source"
+ bridge -d mdb get dev br0 grp $grp src $src1 vid 10 &> /dev/null
+ check_err $? "(S, G) entry for source $src1 deleted after failed replace"
+ bridge -d mdb get dev br0 grp $grp src $src2 vid 10 &> /dev/null
+ check_err $? "(S, G) entry for source $src2 deleted after failed replace"
+ bridge -d mdb get dev br0 grp $grp src $src3 vid 10 &> /dev/null
+ check_fail $? "(S, G) entry for source $src3 created after failed replace"
+
+ bridge mdb del dev br0 port $swp1 grp $grp vid 10
+
# Check that protocol can be modified.
bridge mdb add dev br0 port $swp1 grp $grp temp vid 10 \
filter_mode exclude source_list $src1 proto zebra
@@ -568,8 +586,9 @@ cfg_test_port_ip_star_g()
cfg_test_port_common "IPv4 (*, G)" "grp 239.1.1.1"
cfg_test_port_common "IPv6 (*, G)" "grp ff0e::1"
- __cfg_test_port_ip_star_g "IPv4" "239.1.1.1" "224.0.0.1" "192.0.2."
- __cfg_test_port_ip_star_g "IPv6" "ff0e::1" "ff02::1" "2001:db8:1::"
+ __cfg_test_port_ip_star_g "IPv4" "239.1.1.1" "224.0.0.1" "192.0.2." \
+ "0.0.0.0"
+ __cfg_test_port_ip_star_g "IPv6" "ff0e::1" "ff02::1" "2001:db8:1::" "::"
}
__cfg_test_port_ip_sg()
--
2.56.0
prev parent reply other threads:[~2026-11-22 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 7:25 [PATCH net 1/2] bridge: mcast: Fix source list rollback on failure Ido Schimmel
2026-11-22 7:25 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122072504.2623702-2-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kyuwoncho18@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox