From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795358989; b=d5PgtbLuBKG+KQiU4TRCgnUNWpzJf5hqm7BMlMTW03mskisctPtHLr3WHVTMWca9otGS 3VYlEnOttC7EsHqv8zgqctbp8pkokx3iMKGueK+t+nAH8TeXV1A9Lt43PF5WkpOBmLXLC ofSoz2oRn+AxOWJVqTRAWV28mgBddnAKU20wSXkqSrEm/1sweTCLKzOsbfOqhntYgNcVo zty2Bi5BLr5DNDmQz+M9P9Zbo06CZDtOK3+aFfYHtJ4a2ijIbico+xLXzzHgBiKdcEDii v4/1s5nccSZGkTjT7eLIZQtQWuS/VTYJy1StxgKtOw1ergMueim8CTxxMwuiA3zV61A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795358989; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=90uW9vPXKmWFpzCjI8Up2KnoezPG5Nbi1kLisqyflSw=; b=o5+heM8KDlVa/P+AqK+9I4v6cya2lw3UV7t9fxD8UMnvnIknVTVGffUo+nPLUUVRIf9k qgdSeP24tXEh9kSMNnfd0B7Y8g+UAA+oVvy8niwMg2tATmew2kxv/jjZQIlc19WmM0Bt+ PH+AlDtASQp4pF/I0PVEjMhcb82C83tKva8wcSwxFD8HWf+KcDrWTHwvd4fgh3PPgnl6l LiHD3zuww1Ec4ueu6cdbclkgv/Vxwq2MEIeMYFhSUWf52FFLxpsebkjRPMMvIZLhSn7KQ NJ8pIP/sZ5OhdL5GdefpSuoq1aChne0G+7hIxjLONn+rLUBlF0LZWC6kBg72eahG7sQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=b3pc9oae; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16951606A33A for ; Sun, 22 Nov 2026 14:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 16951606A33A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=b3pc9oae Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id BF9D34E416E1; Sun, 22 Nov 2026 14:49:46 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 93B7D60512; Sun, 22 Nov 2026 14:49:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EAD8111E62396; Sun, 22 Nov 2026 15:49:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795358985; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=90uW9vPXKmWFpzCjI8Up2KnoezPG5Nbi1kLisqyflSw=; b=b3pc9oaep+z/bJD4QxXY7ItQ9Mhm9vK4KSpxC1+FEcS76h22AnJdRuLoNc2vDv2VilJxFk XB10alWQcDGW5eq/DgZ3BjLf0EqkZ5GLTejX3nEtxaOezKR01W/uW5k+u9wXaFSs+dboIo pEo2LIdE1Zi4EZyGfElNeXUfsrrzZ9XSZRJqphfKOmNb5pUtqetPEu52IQfNs77C+A89Ew FFCVUTg+XhoumzBDVsrCjP19/Rcn4T0G+TIX63yPiJ927z1sqUD8F+t+g/tcWrsQE387al WBqva0f/+8krqadVlEp4T/1ZzzzHyE7mvP2VEoERJYKrrdLy4wWRKJTHbzp/1w== From: Maxime Chevallier To: Andrew Lunn , Jakub Kicinski , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Willem de Bruijn , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Coquelin , Alexandre Torgue , Russell King , Lorenzo Bianconi , Nicolai Buchwitz Cc: Maxime Chevallier , thomas.petazzoni@bootlin.com, =?UTF-8?q?Alexis=20Lothor=C3=A9?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH net-next 2/3] net: stmmac: dwmac-sun8i: emit pause frames when the RX FIFO fills Date: Sun, 22 Nov 2026 15:49:24 +0100 Message-ID: <20261122144926.284857-3-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.56.1 In-Reply-To: <20261122144926.284857-1-maxime.chevallier@bootlin.com> References: <20261122144926.284857-1-maxime.chevallier@bootlin.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 The TX flow control mechanism needs multiple things setup to actually work: - The TX_FLOW_CTL_EN bit needs to be set in the TC_FLOW_CTL register, this is already done - The RX fifo thresholds needs to be set, to indicate when the MAC needs to start sending pause frames based on the RX fifo occupancy, and when it should stop. Let's configure the threshold the following way: - Send pause frames when there's less than 2K left in the RX fifo - Stop sending them when there's more than 4K left in the RX fifo. This was tested in Allwinner H2+ using the ethtool -t "flow control" selftest. On that SoC, the RX fifo is 16K. Signed-off-by: Maxime Chevallier --- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index c63f4d87de50..75c743dfe348 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -5,6 +5,7 @@ * Copyright (C) 2017 Corentin Labbe */ +#include #include #include #include @@ -202,6 +203,11 @@ static const struct emac_variant emac_variant_h616_emac1 = { #define EMAC_RX_TH_64 (0x1 << 4) #define EMAC_RX_TH_96 (0x2 << 4) #define EMAC_RX_TH_128 (0x3 << 4) +#define EMAC_RX_FLOW_CTL_TH_ACT GENMASK(21, 20) +#define EMAC_RX_FLOW_CTL_TH_DEACT GENMASK(23, 22) +#define EMAC_RX_FLOW_CTL_TH_2K 0x1 +#define EMAC_RX_FLOW_CTL_TH_4K 0x3 +#define EMAC_RX_FIFO_FLOW_CTL BIT(24) #define EMAC_RX_DMA_EN BIT(30) #define EMAC_RX_DMA_START BIT(31) @@ -766,6 +772,17 @@ static void sun8i_dwmac_flow_ctrl(struct mac_device_info *hw, v &= ~EMAC_RX_FLOW_CTL_EN; writel(v, ioaddr + EMAC_RX_CTL0); + v = readl(ioaddr + EMAC_RX_CTL1); + v &= ~(EMAC_RX_FIFO_FLOW_CTL | EMAC_RX_FLOW_CTL_TH_ACT | + EMAC_RX_FLOW_CTL_TH_DEACT); + if (fc & FLOW_TX) + v |= EMAC_RX_FIFO_FLOW_CTL | + FIELD_PREP(EMAC_RX_FLOW_CTL_TH_ACT, + EMAC_RX_FLOW_CTL_TH_2K) | + FIELD_PREP(EMAC_RX_FLOW_CTL_TH_DEACT, + EMAC_RX_FLOW_CTL_TH_4K); + writel(v, ioaddr + EMAC_RX_CTL1); + v = readl(ioaddr + EMAC_TX_FLOW_CTL); if (fc & FLOW_TX) v |= EMAC_TX_FLOW_CTL_EN; -- 2.56.1