From: Michal Kubecek <mkubecek@suse.cz>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>,
netdev@vger.kernel.org, Dept-HSGLinuxNICDev@qlogic.com,
gregory.v.rose@intel.com, linux-net-drivers@solarflare.com,
Ariel.Elior@qlogic.com, amirv@mellanox.com
Subject: Re: [RFC v2 1/1] net: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.
Date: Wed, 26 Mar 2014 08:37:03 +0100 [thread overview]
Message-ID: <2029402.2DirnyqmAY@alaris> (raw)
In-Reply-To: <1395687300.2832.37.camel@deadeye.wl.decadent.org.uk>
On Monday 24 of March 2014 18:55:00 Ben Hutchings wrote:
>
> Also, this special-casing of -1 isn't documented anywhere. Is it even
> necessary? If userland needs to set just one limit, it can read the
> existing limits and set both.
Wouldn't this open a window for a race if one process wanted to change
one limit and another process wanted to change the other at the same
time? Such scenario doesn't sound very realistic but our customers
taught me that things I don't find very realistic tend to be used quite
frequently by them.
On the other hand, if changing only one limit is going to be common, it
might be more appropriate to add IFLA_VF_TX_MIN_RATE instead and always
pass the minimum and maximum rate separately (and pass only one if only
one is going to be changed).
Michal Kubecek
next prev parent reply other threads:[~2014-03-26 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 4:57 [RFC v2 0/1]: Add minimum bandwidth support in IP tool Sucheta Chakraborty
2014-03-24 4:57 ` [RFC v2 1/1] net: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool Sucheta Chakraborty
2014-03-24 18:55 ` Ben Hutchings
2014-03-26 7:25 ` Sucheta Chakraborty
2014-03-26 7:37 ` Michal Kubecek [this message]
2014-03-28 0:26 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2029402.2DirnyqmAY@alaris \
--to=mkubecek@suse.cz \
--cc=Ariel.Elior@qlogic.com \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=amirv@mellanox.com \
--cc=ben@decadent.org.uk \
--cc=gregory.v.rose@intel.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox