From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A23F1C4332F for ; Sun, 25 Dec 2022 06:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbiLYGou (ORCPT ); Sun, 25 Dec 2022 01:44:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiLYGot (ORCPT ); Sun, 25 Dec 2022 01:44:49 -0500 X-Greylist: delayed 430 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 24 Dec 2022 22:44:47 PST Received: from dvalin.narfation.org (dvalin.narfation.org [213.160.73.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B33636D; Sat, 24 Dec 2022 22:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1671950255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dsaLD4xQX6KhJrIQDNipCfva2ZF6tm0ZP6l23EoxfMY=; b=wn6lqu3Rn/s+0IndgwyVj03DCmm7oQMZeP29dBYtu33DPnyesMY6FzEvGJ8+yn2gQEZ/Fl BMBpuuyHc3qi/gYT+nsrpFna01fittg6xlTSFb4+BBSOAts1tGYOU6ej6p3JlJp9vZ5H6A YClkn2dAatx/UXtbNWhi6mvsx/lMI0U= From: Sven Eckelmann To: Artem Chernyshev Cc: Artem Chernyshev , Marek Lindner , Simon Wunderlich , b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Markus Pargmann Subject: Re: [PATCH] batman-adv: Check return value Date: Sun, 25 Dec 2022 07:37:28 +0100 Message-ID: <2038034.tdWV9SEqCh@sven-l14> In-Reply-To: <20221224233311.48678-1-artem.chernyshev@red-soft.ru> References: <20221224233311.48678-1-artem.chernyshev@red-soft.ru> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2327203.irdbgypaU6"; micalg="pgp-sha512"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --nextPart2327203.irdbgypaU6 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: Artem Chernyshev Subject: Re: [PATCH] batman-adv: Check return value Date: Sun, 25 Dec 2022 07:37:28 +0100 Message-ID: <2038034.tdWV9SEqCh@sven-l14> In-Reply-To: <20221224233311.48678-1-artem.chernyshev@red-soft.ru> References: <20221224233311.48678-1-artem.chernyshev@red-soft.ru> MIME-Version: 1.0 Subject is missing something like ..." after calling rtnl_link_register()" or ..."s during module initialization". On Sunday, 25 December 2022 00:33:11 CET Artem Chernyshev wrote: [...] > diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c > index e8a449915566..04cd9682bd29 100644kwin > @@ -113,7 +113,11 @@ static int __init batadv_init(void) > goto err_create_wq; > > register_netdevice_notifier(&batadv_hard_if_notifier); > - rtnl_link_register(&batadv_link_ops); > + ret = rtnl_link_register(&batadv_link_ops); > + if (ret) { > + pr_err("Can't register link_ops\n"); > + goto err_create_wq; > + } > batadv_netlink_register(); > > pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) loaded\n", > This looks wrong to me. You missed to destroy the batadv_hard_if_notifier in this case. And if you want to start adding the checks, you should also have added it for batadv_v_init, batadv_iv_init, batadv_nc_init, batadv_tp_meter_init and register_netdevice_notifier. You can use the unfinished patch from Markus Pargmann as starting point. Kind regards, Sven [1] https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/1419594103-10928-6-git-send-email-mpa@pengutronix.de/ https://lists.open-mesh.org/mailman3/hyperkitty/list/b.a.t.m.a.n@lists.open-mesh.org/thread/QDX46YARWUC4R7OBFHR5OJKWQIXDQWRR/#QDX46YARWUC4R7OBFHR5OJKWQIXDQWRR --nextPart2327203.irdbgypaU6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmOn76kACgkQXYcKB8Em e0Z8zQ/9FXvbfIwkRg+uE3snrtNgmCRkPYlxNfFA/ktC8MAFyXtp6VGWLkQUssBD t6nmbGBTFX9CPR1C8stqIKJnL3GPjldEXesr7zpkCR7ai7J8CsGF0j812hYfIitO P22uzLMrWV/i1APmeee2PJDw4narHGCsgqPePp2vZO43rdqb73z6nbMqVtZT+PqD Tfb70NjmflrHbgh9oP0L+rFfDJMbWuGNv2C4upfeDJss+oulOFEp1XK5scogITJU VyIxj+El+FPAPkKylMiNej4o06O6U464uYjVoPlgQRkXzyfIA7nuc4qtaUktJqNb wu9gKDL8DMGaOmIHUSm2FFLxcOi1HCSRl5D9mSPAXb8OTL8vnaOEg/Y4UKZRhEhH lZVKi5y7ncIZlTMGgGl8YMPq/zJR+cPSVdeDhhUhMqkNxWeqhPzf4kDEf+sYuMFW XgD9eDY/+o0tQol1zWQOLysUA1flLKanOtLxBHjv5v2EkXLh43GZQSHWT1R5tTKX ssM3GmZ3nObg6aVUBOIlE15Wi/WuzsL7l2JT7ZlvD6jnE85hesJU+9V46KAEg60k vCzwzEnpoz+xWYxy1hTaDln62PIBL53K9TliMkTZCflKgGMkIqidSbY0C2+F32d7 dC8OKU4/i+y0+5axnqxsdT21hE/W0DoXb46HxaluNF+jYR9hiJU= =YzUQ -----END PGP SIGNATURE----- --nextPart2327203.irdbgypaU6--