From: Marek Vasut <marex@nabladev.com>
To: Fidelio Lawson <lawson.fidelio@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marek Vasut <marex@denx.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Tristram Ha <Tristram.Ha@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Fidelio Lawson <fidelio.lawson@exotec.com>
Subject: Re: [PATCH v5 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables
Date: Tue, 5 May 2026 15:25:45 +0200 [thread overview]
Message-ID: <203945a0-4712-45c6-8940-f0148195effe@nabladev.com> (raw)
In-Reply-To: <20260505-ksz87xx_errata_low_loss_connections-v5-3-da4002b21c42@exotec.com>
On 5/5/26 1:42 PM, Fidelio Lawson wrote:
[...]
> static int ksz9021_load_values_from_of(struct phy_device *phydev,
> const struct device_node *of_node,
> u16 reg,
> @@ -6809,6 +6861,8 @@ static struct phy_driver ksphy_driver[] = {
> /* PHY_BASIC_FEATURES */
> .config_init = kszphy_config_init,
> .match_phy_device = ksz8795_match_phy_device,
> + .get_tunable = ksz87xx_get_tunable,
> + .set_tunable = ksz87xx_set_tunable,
It might be good to keep the function name prefix consistent, i.e.
ksz8795_get_tunable and ksz8795_set_tunable . Or add a separate rename
patch for ksz8795_match_phy_device -> ksz87xx_match_phy_device.
next prev parent reply other threads:[~2026-05-05 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 11:42 [PATCH v5 0/3] ksz87xx: add support for low-loss cable equalizer errata Fidelio Lawson
2026-05-05 11:42 ` [PATCH v5 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Fidelio Lawson
2026-05-05 13:23 ` Marek Vasut
2026-05-05 11:42 ` [PATCH v5 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Fidelio Lawson
2026-05-05 11:42 ` [PATCH v5 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Fidelio Lawson
2026-05-05 13:25 ` Marek Vasut [this message]
2026-05-05 13:26 ` [PATCH v5 0/3] ksz87xx: add support for low-loss cable equalizer errata Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=203945a0-4712-45c6-8940-f0148195effe@nabladev.com \
--to=marex@nabladev.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidelio.lawson@exotec.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lawson.fidelio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox