netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: hong liu <hong.liu96@gmail.com>
To: netdev@vger.kernel.org
Subject: question about tcp_ack_update_window
Date: Thu, 17 Sep 2009 11:24:03 +0800	[thread overview]
Message-ID: <204986780909162024s785004e3q319f1b85c68f66@mail.gmail.com> (raw)

Hi,

In tcp_ack_update_window, we don't scale the window if it's a SYN packet.
This modification is introduced by Kevin Lahey during 2.5.75
(http://oss.sgi.com/archives/netdev/2003-10/msg01391.html).

tcp_ack_update_window is only called by tcp_ack, which is called by
tcp_rcv_synsent_state_process & tcp_rcv_established, and we change the
snd_wnd back to th->window in tcp_rcv_synsent_state_process, so why we
still need this  check in tcp_ack_update_window?

I think we may need to add tp->max_window = tp->snd_wnd in
tcp_rcv_syssent_state_process if we remove the check in tcp_ack_update_window.

The only problem I can see is: client entered into established state and sent
an ack (the last packet in 3-way handershake) to the server, but the packet
got lost / arrived slightly late. Then server resent a SYN+ACK packet,
then client can get a SYN packet and call tcp_ack in tcp_rcv_established.

Is this the only concern?

Thanks,
Hong

                 reply	other threads:[~2009-09-17  3:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=204986780909162024s785004e3q319f1b85c68f66@mail.gmail.com \
    --to=hong.liu96@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).