From: Vladis Dronov <vdronov@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, syzkaller@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: arp, ipv6: handle special case of tap device
Date: Wed, 3 Oct 2018 09:25:12 -0400 (EDT) [thread overview]
Message-ID: <2058134821.17788321.1538573112620.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20181002.222540.1948082296309410659.davem@davemloft.net>
> From: "David Miller" <davem@davemloft.net>
> Sent: Wednesday, October 3, 2018 7:25:40 AM
>
> > Probably, this functionality is already used by some userspace, so I
> > believe, I cannot just remove TUNSETLINK ioctl.
>
> Who uses it, how do they use it, and what do they sanely expect about
> the link layer header properties of a tap device which has had ->type
> changed?
Honestly, I have no idea. I was working on a syzkaller bug report and
found that the reason for that bug was TUNSETLINK ioctl.
This ioctl was introduced 13 years ago with ff4cc3ac93e1d and it says:
> For use with
> wireless and other networking types it should be possible to set the
> ARP type via an ioctl.
, that's all. Let me try to prepare a patch that sets dev->addr_len and
dev->broadcast according to dev->type. I would probably need an advise
what other fields must be adjusted too.
Otherwise, we can just to remove the TUNSETLINK ioctl.
Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer
next prev parent reply other threads:[~2018-10-03 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 9:30 [PATCH] net: arp, ipv6: handle special case of tap device Vladis Dronov
2018-09-29 18:40 ` David Miller
2018-10-01 11:32 ` Vladis Dronov
2018-10-03 5:25 ` David Miller
2018-10-03 13:25 ` Vladis Dronov [this message]
2018-10-03 16:37 ` David Miller
2018-10-04 9:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2058134821.17788321.1538573112620.JavaMail.zimbra@redhat.com \
--to=vdronov@redhat.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).