From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection Date: Mon, 11 Jun 2018 16:37:59 -0700 Message-ID: <20599722-9a2f-38c8-e4b8-d2eaf40197ab@gmail.com> References: <5b1f0292.IdMQh83ac/EN53Sl%fllinden@amazon.com> <631FD61F-40EF-4B6A-BD30-6C208DD450B7@amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: "van der Linden, Frank" , "edumazet@google.com" , "netdev@vger.kernel.org" Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:36763 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932471AbeFKXiC (ORCPT ); Mon, 11 Jun 2018 19:38:02 -0400 Received: by mail-pg0-f67.google.com with SMTP id m5-v6so10509514pgd.3 for ; Mon, 11 Jun 2018 16:38:02 -0700 (PDT) In-Reply-To: <631FD61F-40EF-4B6A-BD30-6C208DD450B7@amazon.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/11/2018 04:25 PM, van der Linden, Frank wrote: > A few comments on this one: > > - obviously this is fairly serious, as it can let corrupted data all the way up to the application Sure, although anyone relying on CRC checksum for ensuring TCP data integrity has big troubles ;) I would rather have a refined version of this patch doing a "goto csum_error" so that we properly increment TCP_MIB_CSUMERRORS and TCP_MIB_INERRS Thanks !