From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958E6C282CB for ; Tue, 5 Feb 2019 22:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EDD42054F for ; Tue, 5 Feb 2019 22:12:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ixgMzaJb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728693AbfBEWMv (ORCPT ); Tue, 5 Feb 2019 17:12:51 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38832 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfBEWMu (ORCPT ); Tue, 5 Feb 2019 17:12:50 -0500 Received: by mail-wm1-f68.google.com with SMTP id m22so616293wml.3 for ; Tue, 05 Feb 2019 14:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=46r7ZME8j8ODK7NkdIQ25KCz0/nqlseqCOsN6X85EA8=; b=ixgMzaJblRTeYV8P6sNt5r2JI4LD2flRuX2B7Vz1PD8qXPKJdbK0/g86YOXatSqaNj wgw3hXmBy7PaYmWhFrRMnZ026PlYli7FHONoqZ7TLEtEd9cnFudMDILYBfr/2uOTyd4U /573cPu3uzbNONVUsJ4nAd7oJ3fDCBTG5ygTCAdMFsJ+JwLO9jTY2xWVVLo9gLBtkT73 M2rrB0fRDrlATv88+fvsqLY0zmKf5RwB24erYBBiibB0gbctXIKlajNRRouJq4g3Jszt OxktZiDrjXtqWz5EBOgKin9brJejhDTBKa2+YJ5ZfZeOhF98biPBPy03QeQOXKRt6TO2 Fp+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=46r7ZME8j8ODK7NkdIQ25KCz0/nqlseqCOsN6X85EA8=; b=P5jgIxNQW+ZzhLTJ8N1LjLaFdlRKv1Qm34Ats6rLNvgvNSQxj02q9dASw1uYovRUVH v+czSmhgEqtA4ju+arL42E6GaUwNi61GJzOoO5HrTRVMH8Zp8QWJoFTge3jHAOH1fDr6 9NwLE6+0DtdIVVSMwnFguMdilh/WoZpFOjpA0Souu+HAiYCkuujJ381JR+oJRAe77fAm lcMGBMiHAs2dyax4GDT5BzrzSlmZvrXaSxksijxTqUosPhrOpCDZNZRL0fkn2LjIrFFr Bp1BMS5Tf37ThtgMF44lwYWPcpPWZSGLQ6PjaIYR+2y/NojJe/WA7U11aBx/GQOBiJOT 1d7g== X-Gm-Message-State: AHQUAuZkcq/+X8o/0osO2dAcH0KtjDnIK4QficQQDnUYW3EoH/P0BFCm 8qfQE17CMwr0v6OUYO/aRyU= X-Google-Smtp-Source: AHgI3IYyJ++1Rzdp1vydHBP6Pir2je5hKixgaBz19AU6Zc8D/F/S+hM8kSpEfqUNLE0sixCPkj7lYw== X-Received: by 2002:a1c:4d12:: with SMTP id o18mr660449wmh.92.1549404768145; Tue, 05 Feb 2019 14:12:48 -0800 (PST) Received: from debian64.daheim (p5B0D715E.dip0.t-ipconnect.de. [91.13.113.94]) by smtp.gmail.com with ESMTPSA id h17sm2399576wrq.17.2019.02.05.14.12.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 14:12:46 -0800 (PST) Received: from localhost.daheim ([127.0.0.1] helo=debian64.localnet) by debian64.daheim with esmtp (Exim 4.92-RC5) (envelope-from ) id 1gr8xR-0007xh-Im; Tue, 05 Feb 2019 23:12:45 +0100 From: Christian Lamparter To: Andrew Lunn Cc: netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation Date: Tue, 05 Feb 2019 23:12:45 +0100 Message-ID: <2061891.QOleSDBFsG@debian64> In-Reply-To: <20190205212934.GF3243@lunn.ch> References: <20190204213555.26054-1-chunkeey@gmail.com> <2630352.e1UqcK5yIU@debian64> <20190205212934.GF3243@lunn.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote: > > For now, I added the DT binding update to the patch as well. > > But if this is indeed the way to go, it'll get a separate patch. > > Hi Christian > > You need to be careful with the DT binding. You need to keep backwards > compatible with it. An old DT blob needs to keep working. I don't > think this is true with this change. Do you mean because of the - switch0@0 { + switch@10 { compatible = "qca,qca8337"; #address-cells = <1>; #size-cells = <0>; - reg = <0>; + reg = <0x10>; change? or because I removed the phy-handles? The reg = <0x10>; will be necessary regardless. Because this is really a bug in the existing binding example and if it is copied it will prevent the qca8k driver from loading. This is due to a resource conflict, because there will be already a "phy_port1: phy@0" registered at reg = <0>; So this never worked would have worked. Regards, Christian