From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FB0C2B9F2 for ; Sat, 22 May 2021 20:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B727861177 for ; Sat, 22 May 2021 20:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231386AbhEVUrq (ORCPT ); Sat, 22 May 2021 16:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbhEVUrp (ORCPT ); Sat, 22 May 2021 16:47:45 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F747C061574 for ; Sat, 22 May 2021 13:46:19 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id lz27so35650985ejb.11 for ; Sat, 22 May 2021 13:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UzMmyceO3Q/ZlHgmxpgCoi1VldstNjhJayiNr3tNQRk=; b=NpUnqKMPK2JsZ7Q6Ba6TXg9/RWU81TnevSpOcK0UdkAV5WUKb0EbLQiUi/ZTGfSror 4qlDgf+EpGsbwNsCXaGF8FyIoiHjLNtIvcy0wwRFP8sfXWkUhDyZ+bfahDTCA3rYum/q QMSYpM77bV2Lwym+AX33A4EOAxeJgNCWPFS1aJCTNXijgLRhy1pKfzKb+Hh1iipmbK3l BYORJtYS1vHbsrq2AwUFQ+CJ0yJl2jbbMq1Y2CwQyKRApsy6+yuIO+jlzgN5KL+WA6AT /J4NboAf4EYOPZQgCcFmSmETGnRlmktLVvCFqxrXQkuKc4Y2YydqqX9hHiyQhSgX/B2A IM8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UzMmyceO3Q/ZlHgmxpgCoi1VldstNjhJayiNr3tNQRk=; b=SnSKwFx9MqL8LqDXISfQS0g/ovPoXMgaVvjcTT4RfoM/iqxpZM0Zeh5K+oY75rQA8h 11+//bJYWC1fvuQBt4cBJpx1PGVzuEXLb+8djZQw4ZKCEpDUFhb1HF6UAGtfAMqBl3jO AoXQKtJwnOg+Gkk822Lc+C3EAvXVQYjax+cr708peGe1alBNE+ZZgDitrWmivI/id0Zr z5UyTCEOA6Dz/0NPWmwSC9UfqUFKVGdfn09JBiHj4Xf4lRVssfFK2TtKGAy0xDde3CvE py0X9PP0auLlTPe4CA2ObaaG6FDTSg9Kf9Vm4jH7BpmSphpHUkri/nnz6OndfWgP1nlY GCJg== X-Gm-Message-State: AOAM531lwyk6C65vjkVDTcWzBPm2at47Q1eRjLTFUBm7qdDDm3NbPDiE iB2fLI2z1Jvl4YVRi/0Suss= X-Google-Smtp-Source: ABdhPJxyE80Dkrd3qshMDHh2/F9uKhsJlqfq/lYt8yRPIp4dAzEj41RQz2dZRyYuT+qaD2PjBp7rMw== X-Received: by 2002:a17:906:46d1:: with SMTP id k17mr15887691ejs.77.1621716376728; Sat, 22 May 2021 13:46:16 -0700 (PDT) Received: from [192.168.0.129] ([82.137.32.75]) by smtp.gmail.com with ESMTPSA id v8sm5729082ejq.62.2021.05.22.13.46.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 May 2021 13:46:16 -0700 (PDT) Subject: Re: [net-next, v2, 7/7] enetc: support PTP domain timestamp conversion To: Yangbo Lu , netdev@vger.kernel.org Cc: "David S . Miller" , Richard Cochran , Claudiu Manoil , Jakub Kicinski References: <20210521043619.44694-1-yangbo.lu@nxp.com> <20210521043619.44694-8-yangbo.lu@nxp.com> From: Claudiu Manoil Message-ID: <206a857a-625c-e604-9916-7f73f79d191c@gmail.com> Date: Sat, 22 May 2021 23:46:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210521043619.44694-8-yangbo.lu@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org hi Yangbo, On 21.05.2021 07:36, Yangbo Lu wrote: > Support timestamp conversion to specified PTP domain in PTP packet. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - Fixed build waring. > - Updated copyright. > --- > drivers/net/ethernet/freescale/enetc/enetc.c | 39 ++++++++++++++++++-- > 1 file changed, 35 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c > index 3ca93adb9662..cd0429c73999 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc.c > +++ b/drivers/net/ethernet/freescale/enetc/enetc.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > -/* Copyright 2017-2019 NXP */ > +/* Copyright 2017-2021 NXP */ > > #include "enetc.h" > #include > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > > static int enetc_num_stack_tx_queues(struct enetc_ndev_priv *priv) > @@ -472,13 +473,36 @@ static void enetc_get_tx_tstamp(struct enetc_hw *hw, union enetc_tx_bd *txbd, > *tstamp = (u64)hi << 32 | tstamp_lo; > } > > -static void enetc_tstamp_tx(struct sk_buff *skb, u64 tstamp) > +static int enetc_ptp_parse_domain(struct sk_buff *skb, u8 *domain) > +{ > + unsigned int ptp_class; > + struct ptp_header *hdr; > + > + ptp_class = ptp_classify_raw(skb); > + if (ptp_class == PTP_CLASS_NONE) > + return -EINVAL; > + > + hdr = ptp_parse_header(skb, ptp_class); > + if (!hdr) > + return -EINVAL; > + > + *domain = hdr->domain_number; > + return 0; > +} > + Why is this function defined inside the enetc driver? I don't see anything enetc specific to it, but it looks like another generic ptp procedure, similar to ptp_parse_header() or ptp_clock_domain_tstamp().