From: Mikael Pettersson <mikpe@it.uu.se>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: netdev@vger.kernel.org, Imre Kaloz <kaloz@openwrt.org>,
Xi Wang <xi.wang@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: ixp4xx eth broken in 3.7.0/3.8-rc5?
Date: Wed, 30 Jan 2013 01:11:08 +0100 [thread overview]
Message-ID: <20744.25884.660535.514911@pilspetsen.it.uu.se> (raw)
In-Reply-To: <20744.9777.937924.822371@pilspetsen.it.uu.se>
Mikael Pettersson writes:
> When I try to update my ixp4xx machine to a 3.8-rc5 kernel it boots
> Ok but the network (CONFIG_IXP4XX_ETH=y) fails to come up, with the
> following in the kernel log:
>
> net eth0: coherent DMA mask is unset
>
> With a 3.7.0 kernel the situation is similar, except that the "net
> eth0: coherent DMA mask is unset" message repeats itself endlessly
> and I can't even get in on the serial console.
>
> With the 3.6.0 kernel everything works perfectly.
A git bisect identified the following as the culprit:
> From 1a4901177574083c35fafc24c4d151c2a7c7647c Mon Sep 17 00:00:00 2001
> From: Xi Wang <xi.wang@gmail.com>
> Date: Sat, 17 Nov 2012 20:25:09 +0000
> Subject: [PATCH] ixp4xx_eth: avoid calling dma_pool_create() with NULL dev
>
> Use &port->netdev->dev instead of NULL since dma_pool_create() doesn't
> allow NULL dev.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/ethernet/xscale/ixp4xx_eth.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
Reverting this unbreaks ixp4xx_eth on my ixp4xx machine with kernels
3.7.0 and 3.8-rc5.
(Added cc: author and netdev.)
/Mikael
next parent reply other threads:[~2013-01-30 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20744.9777.937924.822371@pilspetsen.it.uu.se>
2013-01-30 0:11 ` Mikael Pettersson [this message]
2013-01-30 0:32 ` ixp4xx eth broken in 3.7.0/3.8-rc5? Xi Wang
2013-01-30 1:34 ` Ben Hutchings
2013-01-30 10:11 ` Mikael Pettersson
2013-01-30 20:50 ` Mikael Pettersson
2013-01-31 21:54 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20744.25884.660535.514911@pilspetsen.it.uu.se \
--to=mikpe@it.uu.se \
--cc=kaloz@openwrt.org \
--cc=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox