From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from vulcan.natalenko.name ([104.207.131.136]:17312 "EHLO
        vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750716AbeBUGOw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Feb 2018 01:14:52 -0500
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Neal Cardwell <ncardwell@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net-next 0/6] tcp: remove non GSO code
Date: Wed, 21 Feb 2018 07:14:49 +0100
Message-ID: <2077050.JV33r27xBe@natalenko.name>
In-Reply-To: <1519168897.55655.31.camel@gmail.com>
References: <20180219195652.242663-1-edumazet@google.com> <2638137.lzCXOlOYsz@natalenko.name> <1519168897.55655.31.camel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi.

On st=C5=99eda 21. =C3=BAnora 2018 0:21:37 CET Eric Dumazet wrote:
> My latest patch (fixing BBR underestimation of cwnd)
> was meant for net tree, on a NIC where SG/TSO/GSO) are disabled.
>=20
> ( ie when sk->sk_gso_max_segs is not set to 'infinite' )
>=20
> It is packet scheduler independent really.
>=20
> Tested here with pfifo_fast, TSO/GSO off.

Well, before the patch with BBR and sg off here it is ~450 Mbps for fq and=
=20
~115 Mbps for pfifo_fast. So, comparing to what I see with the patch (850 a=
nd=20
200 respectively), it is definitely an improvement.

Thanks.