From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7527C43381 for ; Mon, 1 Apr 2019 17:40:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A098220896 for ; Mon, 1 Apr 2019 17:40:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KY9LWde2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387996AbfDARk0 (ORCPT ); Mon, 1 Apr 2019 13:40:26 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40899 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387696AbfDARjS (ORCPT ); Mon, 1 Apr 2019 13:39:18 -0400 Received: by mail-wm1-f68.google.com with SMTP id z24so310277wmi.5 for ; Mon, 01 Apr 2019 10:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K1vWiBuKh1+r94rj1C44iM/gnZy5dL9wOZf0mPPpAMc=; b=KY9LWde2QH0hKCPVpz7Aay2JdkFN6qS2+tRDJC258bxL9rKHcX7ZZJiUPZ/BRsXYGx JkIwXKlW4KfJTzm6BxsFlGD/XCJeWRF/fzQDa7Dx+vxDbUyKPJK16rWWM9kyNcNtnSNa Iw5cw298EkU85d+8jNcHsJbeGf08cuL/VZRQf6c9TSaTHtoqkWQVX0sn6TPh0pkRfR7V iIzPr8AppTK5ambEkWmXmnTcg58Ap67nO01namx3p0fV1GEAA3ovUfvQuQquGD2gMg1t eX5ZMTbAEWbg7nSRqRRHtPWPwcGkWbf83NSLjZUwwg0P0uyFYHVI9L/MFpDNgsxUon+s OZGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K1vWiBuKh1+r94rj1C44iM/gnZy5dL9wOZf0mPPpAMc=; b=CvYTMPvTlVvg8dq69Ih4bqsVNCFvi9gK//livDVbJjJbn1vwYHCjNMDppoFPFeTbJ2 loZ0ZlwBbsFbuvLQJD4OGvixvSRm/szOHaRyTYl58jIDdjWhJA3xcV3pTu/mhYMfz0E5 eNwI1JsjEEUTF/EvvizhoFoDm/Wl8rmcnglqXsXTnQ9sPYar9mHApo7t+CDPMRTftYj0 D249wRwLdaCw8b5OFeqD79SruFafl+WBc6Tn5+bbRIcibMgtq8abPAPFHSqhzJfi3L8T 7p+vS79ZSkiRmQ8kJ7hkxu6j3pk58LKK3f+qCRvEQTD75zB1N6t8ZKkOYkyRsWFs1V4b SlaQ== X-Gm-Message-State: APjAAAV0PQtHz99rNMiur8qJ78VDwilCmXQgKwYaLA3c1X+84JEOCwMj Fo/8wW0vhmwpDVGIwbFAa0oT0gWI X-Google-Smtp-Source: APXvYqzavSiC3w6HdBGY4vpZsnxdW5jauNjutdPl1BY4HXsYwKQ8wPyeiaceaUSjE2aui3bE/oZvhg== X-Received: by 2002:a1c:c18d:: with SMTP id r135mr508293wmf.112.1554140356671; Mon, 01 Apr 2019 10:39:16 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:c53:1f49:856e:d602? (p200300EA8BE1DD000C531F49856ED602.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:c53:1f49:856e:d602]) by smtp.googlemail.com with ESMTPSA id a126sm11776299wmh.4.2019.04.01.10.39.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:39:15 -0700 (PDT) Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching To: Edward Cree , David Miller , eric.dumazet@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, brouer@redhat.com References: <20190331.111114.1510038068515936853.davem@davemloft.net> <61e68943-fb2c-ff89-90e6-1d2742c56687@gmail.com> <20190401.101419.1397780796470309064.davem@davemloft.net> From: Heiner Kallweit Message-ID: <207c232c-1ade-ff54-4384-76f4d0280a7d@gmail.com> Date: Mon, 1 Apr 2019 19:39:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01.04.2019 19:31, Edward Cree wrote: > On 01/04/2019 18:14, David Miller wrote: >> From: Eric Dumazet >> Date: Mon, 1 Apr 2019 02:17:12 -0700 >> >>> This means no GRO at all >> I do not think that is true as the SKB list layer does queue up to >> GRO. > No, Eric is right; the current list layer bypasses GRO completely. > > netif_receive_skb_list() ends up doing the same things netif_receive_skb() > would do on each SKB in the list, and that does not include GRO. > (For this reason the sfc driver only uses netif_receive_skb_list() for > non-TCP packets; TCP packets go to napi_gro_frags().) > I had a patch series to add napi_gro_receive_list() which would use the > SKB list layer to handle the packets GRO didn't coalesce ([1]) but the > performance tests I ran were inconclusive and it never got applied. > > -Ed > > [1]: https://marc.info/?l=linux-netdev&m=154221888012410&w=2 > Patch 0a25d92c6f4f ("dpaa2-eth: use netif_receive_skb_list") was well perceived [1], therefore I was under the assumption that netif_receive_skb_list is kind of successor for napi_gro_receive(). Does what you say apply to that patch too? Based on feedback so far it seems to best if I revert the patch. Heiner [1] https://patchwork.ozlabs.org/patch/1064334/