From: Cong Wang <amwang@redhat.com>
To: David Ward <david.ward@ll.mit.edu>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net/802/mrp: fix possible race condition when calling mrp_pdu_queue()
Date: Fri, 12 Apr 2013 04:18:13 -0400 (EDT) [thread overview]
Message-ID: <2086091165.2722334.1365754693666.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1365724035-30220-1-git-send-email-david.ward@ll.mit.edu>
----- Original Message -----
> (Adapted from a very similar change to net/802/garp.c by Cong Wang.)
>
> mrp_pdu_queue() should ways be called with the applicant spin lock.
> mrp_uninit_applicant() only holds the rtnl lock which is not enough;
> a race is possible because mrp_rcv() is called in BH context:
>
> mrp_rcv()
> |->mrp_pdu_parse_msg()
> |->mrp_pdu_parse_vecattr()
> |->mrp_pdu_parse_vecattr_event()
> |-> mrp_attr_event()
> |-> mrp_pdu_append_vecattr_event()
> |-> mrp_pdu_queue()
>
> Cc: Cong Wang <amwang@redhat.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Cong Wang <amwang@redhat.com>
Thanks.
next prev parent reply other threads:[~2013-04-12 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 23:47 [PATCH] net/802/mrp: fix possible race condition when calling mrp_pdu_queue() David Ward
2013-04-12 8:18 ` Cong Wang [this message]
2013-04-12 19:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2086091165.2722334.1365754693666.JavaMail.root@redhat.com \
--to=amwang@redhat.com \
--cc=david.ward@ll.mit.edu \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).