From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
Edward Cree <ecree.xilinx@gmail.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
Subject: Re: [PATCH net-next 5/5] ice: dpll: Remove newline at the end of a netlink error message
Date: Wed, 26 Feb 2025 14:48:53 +0100 [thread overview]
Message-ID: <20879a01-348e-4bec-a880-41e8a6904e60@intel.com> (raw)
In-Reply-To: <20250226093904.6632-6-gal@nvidia.com>
On 2/26/25 10:39, Gal Pressman wrote:
> Netlink error messages should not have a newline at the end of the
> string.
>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_dpll.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c
> index 8d806d8ad761..bce3ad6ca2a6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dpll.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c
> @@ -95,7 +95,7 @@ ice_dpll_pin_freq_set(struct ice_pf *pf, struct ice_dpll_pin *pin,
> }
> if (ret) {
> NL_SET_ERR_MSG_FMT(extack,
> - "err:%d %s failed to set pin freq:%u on pin:%u\n",
> + "err:%d %s failed to set pin freq:%u on pin:%u",
[...]
next prev parent reply other threads:[~2025-02-26 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 9:38 [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test Gal Pressman
2025-02-26 9:39 ` [PATCH net-next 1/5] coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with newline test Gal Pressman
2025-02-26 9:39 ` [PATCH net-next 2/5] net/mlx5: Remove newline at the end of a netlink error message Gal Pressman
2025-02-26 9:39 ` [PATCH net-next 3/5] sfc: " Gal Pressman
2025-02-26 9:39 ` [PATCH net-next 4/5] net: sched: " Gal Pressman
2025-02-26 9:39 ` [PATCH net-next 5/5] ice: dpll: " Gal Pressman
2025-02-26 13:48 ` Przemek Kitszel [this message]
2025-02-27 5:41 ` [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test Michal Swiatkowski
2025-02-28 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20879a01-348e-4bec-a880-41e8a6904e60@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=Julia.Lawall@inria.fr \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=habetsm.xilinx@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).