From: "Alexey Klimov" <klimov.linux@gmail.com>
To: "David Brownell" <david-b@pacbell.net>
Cc: "Oliver Neukum" <oliver@neukum.org>,
davem@davemloft.net, "Greg KH" <greg@kroah.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [patch v2] net/usb: remove err() messages in few drivers
Date: Tue, 13 Jan 2009 13:08:27 +0300 [thread overview]
Message-ID: <208cbae30901130208xe47d222g6928cf4243ea1dd8@mail.gmail.com> (raw)
In-Reply-To: <200901130144.26162.david-b@pacbell.net>
On Tue, Jan 13, 2009 at 12:44 PM, David Brownell <david-b@pacbell.net> wrote:
> On Tuesday 13 January 2009, Oliver Neukum wrote:
>> > Ok, i'll reformat patch. Is it okay if i use kaweth->dev->dev,
>> > kaweth->net->dev and intf->dev ? Or switch to kaweth->net->dev
>> > (instead of dev->dev)?
>>
>> kaweth in kaweth_disconnect() frees the network device. Therefore
>> you cannot use it. You'd access freed memory. Pick one of the others
>> and stay with it.
>
> intf->dev is going to be "obviously correct", the others aren't.
>
Is this patch touch kaweth_disconnect() ? I see dev_warn and dev_info
there. No dev_err.
--
Best regards, Klimov Alexey
next prev parent reply other threads:[~2009-01-13 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 0:08 [patch v2] net/usb: remove err() messages in few drivers Alexey Klimov
[not found] ` <1231805322.12962.4.camel-XMdqyYT0w3Zyw3qLyVIJKA@public.gmane.org>
2009-01-13 8:40 ` Oliver Neukum
2009-01-13 8:57 ` Alexey Klimov
2009-01-13 9:25 ` Oliver Neukum
[not found] ` <200901131025.40285.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-13 9:44 ` David Brownell
2009-01-13 10:08 ` Alexey Klimov [this message]
2009-01-13 11:07 ` Oliver Neukum
[not found] ` <200901131207.03724.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-01-14 0:22 ` Alexey Klimov
[not found] ` <208cbae30901131622heccfee6uf312022ba1d4fb28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-14 1:05 ` David Brownell
2009-01-14 8:09 ` Oliver Neukum
2009-01-13 9:46 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208cbae30901130208xe47d222g6928cf4243ea1dd8@mail.gmail.com \
--to=klimov.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).