From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A502F12B3 for ; Thu, 7 May 2026 18:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179160; cv=none; b=LgF2HY+5UYGkttk4e+Sb+IJuK/R1oSBaq639itpmsUw63lZ/yeZrwGIVWvtUILNKk+2e+HXdC2kZEN9u34EovG0Qc2lhr/2XO33XrP/usW3C/bftbwM4hVx4XW91oHQyVDttKRSzC0OPOLj7Zv2+wmlME0tU4PQsmO69n71hphY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179160; c=relaxed/simple; bh=f/VYt86QfsV33lO5nWhjommtwvlcryeqI+nt7Vqb76c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ts/rMptovNoPkppczk2MbekEVbEiMyrgJF7FWa01fDAMJaN6BA9JEv3RiXM5x3bTh8HuG8Wu4TXJ0EG7PnsXKrRhRgevixLg77UIM57spHwMZ3Ftg6uPZnApET1iwq0Ovn+0ol90zho0qi1cnyXws98SWUd9aX6whIHDXpYDpDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=sETjafTP; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="sETjafTP" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8ef0ba61d46so126903085a.2 for ; Thu, 07 May 2026 11:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778179158; x=1778783958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xAxf1DNF2nC8sz42taPRq/pgsGcKQpqrWaLh7UNAXF0=; b=sETjafTPdUg2ii93kH2SRdQpxIDwlHw++/Udnl0YvFhjKxo3mfpZymbm3zCbgKWwy1 ZZTG/CwjDVG41bxom74SCHnJU+/7a9q6J2hC8o83bgco6Dr+7ETgR8oAhevz4ocMQDFX Ljcf7sSF83yMY1IdGcMdSDhhLa5F4ccPXRZr9o4kt7J8RlHc4eMCYebqQvQRTxtJPweY CbSHWFRgCs3jlhl7Ba3jBV+nkiOcv778l8CV5M7TCIdT8z5yhZMO1VXKgy2ghAU+ztSA rPjKoKJOaL9XsTVzUnI29jx+V0ofMTZcgeaBGW+QSjNrvNhH5sSNkCxFd4FPz2sDDIiR oyMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778179158; x=1778783958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xAxf1DNF2nC8sz42taPRq/pgsGcKQpqrWaLh7UNAXF0=; b=tOo8A1sX6Lrbh5hJnjcaMYgyrlB6X69KVPfdGVHeY9R7ZtkS1y4WwMHR6c5QxEFqF1 q/WEjQJqNZOQoOnFeXfRcN6pLxLD0YM3/k0sFDygOjSOuiWirfP3zsSFxtZRcIv+UCO3 Tca+O9+RGX4KhZ4s8tiqSM8/5A7DKiNNJnK4N2flbI0wy47J8yjq1ot2HZ1NoyNcp2qL IN4pAV8/6bz8FtRqfJ0h/5TwttYYNbMImq8ubcU6Cfr5OheZbX7G6Z57fvqUQLzg8HRB qMjVd2gdUlH4a6it94HWRxJqPXwNOeX0Lmv6cTKhPVmE9OiNWsozHLU51R2AqU+FyDjv yReA== X-Forwarded-Encrypted: i=1; AFNElJ+tDanTuY2Adf87f/cayUl6TvPrG3XoFkIkwh55WlxmzD80qdy3hbUybTo7+MIlZ8BDTA9NkIc=@vger.kernel.org X-Gm-Message-State: AOJu0YyiKng1cjdEA5GXSeEnZ9OzqWDzZaXnV/7EcWO4Fn5nIZUmzgve HDrnFXwOb5Cd9uNyx6eC36NDgBO85swXzvapM6cm0F7GNALcMcFTP0tUhtPgzHsaua4= X-Gm-Gg: AeBDiet+8LwFD2iAkA3gkHH1RtYS9nNOtIQ1Zi7/Xcmw48hm6Fi5pi2leZXvwmtv7UL 40U8p/9hhN8q6wOGISblzuSziEq+lOb7qF3DjhF8/Ri6L+OFSxxrDL5mtZU9x32cydIWArH5WyW oVz9eUlsvwkvEcKI66QmSCQbNcV+VqSknRyAZur9TlcHLfdl9JIXdLojbsRMSMFuZFY4Dmoly9t t6awEvAdL3OZGY4uL1dQD3WWsMzj9+De9Om9oMU+ucOsC9H1ZCTQH0/LthaZlMpJk56QDd8K4JF 9vEMnn4/3cLyElrfRyUtlsObvpRzSglkXU/SM8lS4/x5V0HVlgcaBL5DihnZRFBhsLhT79gE4l1 T980DQO/6iMMVejH/3CvemzMxnwcvozBCipjWWe9h7Cy8t0sZ07JDPzBe8k9Uo7ClUvFtII53c1 eHO5sVyvDbPzKzXu8oji8rjuiXEqZpc7PBJCkv7SEcVALbpgUjJSNNB2yxELLJOI2j X-Received: by 2002:a05:620a:40c9:b0:8e9:13ea:a0e1 with SMTP id af79cd13be357-904d496d4abmr1387402085a.18.1778179157638; Thu, 07 May 2026 11:39:17 -0700 (PDT) Received: from [172.22.22.234] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2c25324esm2298627185a.23.2026.05.07.11.39.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 11:39:17 -0700 (PDT) Message-ID: <20903580-85af-4e7b-b3dc-b8de49bd32c1@riscstar.com> Date: Thu, 7 May 2026 13:39:13 -0500 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support To: Andrew Lunn Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-10-elder@riscstar.com> <736fb3b7-c88a-4ec4-96ad-d1b79cc48d30@lunn.ch> <30cec7dd-ac3c-47ab-896a-c29992bd5ba5@riscstar.com> <3e5a42cc-53b8-4065-a32a-d754be40b4c7@lunn.ch> Content-Language: en-US From: Alex Elder In-Reply-To: <3e5a42cc-53b8-4065-a32a-d754be40b4c7@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/2/26 9:48 PM, Andrew Lunn wrote: >> It's possible gpio-regmap.c *could* be used. We started with >> vendor code and this code got separated at some point along >> the way. It was working, and I don't think I pursued other >> options at that point. I'll look at this possibility before we >> send out the next version. > > The GPIO subsystem has made a big effort to provide generic code, > since GPIOs are pretty simple things with a lot in common. So if the > generic code works, or can be made to work with minor changes, you > should use it. Yes, I can confirm this is what I will use. As mentioned elsewhere, LinusW provided a patch that support the one unusual thing this does (input-only GPIO lines). >> What do you mean instantiate it twice? > > I _think_ you need one instance for the first 32 GPIOs, and a second > one for the remaining GPIOs. But maybe config->reg_stride might allow > it to work with a single instance? Oh I see. Looking at it now, I presume the reg_stride will work here. Thanks. -Alex > Andrew