From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>, hancock@sedsystems.ca
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com
Subject: Re: [PATCH net-next] net: phy: Add detection of 1000BaseX link mode support
Date: Thu, 6 Jun 2019 08:05:31 +0200 [thread overview]
Message-ID: <20b0f19b-131d-2db0-dfa6-dac7e5b8d422@gmail.com> (raw)
In-Reply-To: <20190605.184254.1047432851767426057.davem@davemloft.net>
On 06.06.2019 03:42, David Miller wrote:
> From: Robert Hancock <hancock@sedsystems.ca>
> Date: Tue, 4 Jun 2019 16:15:01 -0600
>
>> Add 1000BaseX to the link modes which are detected based on the
>> MII_ESTATUS register as per 802.3 Clause 22. This allows PHYs which
>> support 1000BaseX to work properly with drivers using phylink.
>>
>> Previously 1000BaseX support was not detected, and if that was the only
>> mode the PHY indicated support for, phylink would refuse to attach it
>> due to the list of supported modes being empty.
>>
>> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
>
> Andrew/Florian/Heiner, is there a reason we left out the handling of these
> ESTATUS bits?
>
>
I can only guess here:
In the beginning phylib took care of BaseT modes only. Once drivers for
BaseX modes were added the authors dealt with it in the drivers directly
instead of extending the core.
next prev parent reply other threads:[~2019-06-06 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 22:15 [PATCH net-next] net: phy: Add detection of 1000BaseX link mode support Robert Hancock
2019-06-06 1:42 ` David Miller
2019-06-06 6:05 ` Heiner Kallweit [this message]
2019-06-06 12:27 ` Andrew Lunn
2019-06-06 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20b0f19b-131d-2db0-dfa6-dac7e5b8d422@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hancock@sedsystems.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).