Re: [PATCH net 2/2] selftests: mlxsw: Test port range occupancy on template create

[Jacob Keller <jacob.e.keller@intel.com>]

On 10/6/2026 7:21 AM, Petr Machata wrote:
> Add a test that creates a tc chain template matching on both source and
> destination port ranges and verifies via devlink-resource occupancy that
> this does not leak port range registers, neither while the template
> exists nor after it is deleted.
> 

Nice to see this covered by a selftest :D

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks,
Jake

> Assisted-by: LLM
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
>  .../drivers/net/mlxsw/port_range_occ.sh       | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/tools/testing/selftests/drivers/net/mlxsw/port_range_occ.sh b/tools/testing/selftests/drivers/net/mlxsw/port_range_occ.sh
> index b1f0781f6b25..c7eba3f15066 100755
> --- a/tools/testing/selftests/drivers/net/mlxsw/port_range_occ.sh
> +++ b/tools/testing/selftests/drivers/net/mlxsw/port_range_occ.sh
> @@ -9,6 +9,7 @@ lib_dir=$(dirname $0)/../../../net/forwarding
>  
>  ALL_TESTS="
>  	port_range_occ_test
> +	port_range_occ_tmplt_test
>  "
>  NUM_NETIFS=2
>  source $lib_dir/lib.sh
> @@ -101,6 +102,31 @@ port_range_occ_test()
>  	log_test "port range occupancy"
>  }
>  
> +port_range_occ_tmplt_test()
> +{
> +	local occ
> +
> +	RET=0
> +	occ=$(port_range_occ_get)
> +
> +	# Addition of a chain template should not impact occupancy.
> +	tc chain add dev "$swp1" ingress chain 1 protocol ip \
> +		flower ip_proto udp src_port 501-600 dst_port 701-800
> +	check_err $? "Could not add chain template"
> +
> +	(( occ == $(port_range_occ_get) ))
> +	check_err $? "Got occupancy $(port_range_occ_get), expected $occ"
> +
> +	# And just for completeness sake, neither should deletion.
> +	tc chain del dev "$swp1" ingress chain 1
> +	check_err $? "Could not delete chain template"
> +
> +	(( occ == $(port_range_occ_get) ))
> +	check_err $? "Got occupancy $(port_range_occ_get), expected $occ"
> +
> +	log_test "port range occupancy after template create/destroy"
> +}
> +
>  trap cleanup EXIT
>  
>  setup_prepare