From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sharath Chandra Vurukala <sharathv@codeaurora.org>,
netdev@vger.kernel.org
Cc: chinagar@codeaurora.org, kapandey@codeaurora.org,
subashab@codeaurora.org
Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb()
Date: Fri, 30 Nov 2018 10:40:39 -0800 [thread overview]
Message-ID: <20dde5c1-959e-c14b-9640-82f96e29ff76@gmail.com> (raw)
In-Reply-To: <20181130182828.GA27508@svurukal-linux.qualcomm.com>
On 11/30/2018 10:28 AM, Sharath Chandra Vurukala wrote:
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
>
> tcp_retransmit_skb() returns non-zero negative value in some cases of
> failure but the caller tcp_retransmission_timer() has a check for
> failure which checks if the return value is greater than zero.
> The check is corrected to check for non-zero value.
>
> Signed-off-by: Sharath Chandra Vurukala <sharathv@codeaurora.org>
>
This looks wrong.
Yuchung has cooked a patch series to really address issues, please wait for it
We are waiting for David Miller to merge a prior patch series into net tree, then
in net-next.
Thanks.
next prev parent reply other threads:[~2018-12-01 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 18:28 [PATCH] net: tcp: add correct check for tcp_retransmit_skb() Sharath Chandra Vurukala
2018-11-30 18:40 ` Eric Dumazet [this message]
2018-11-30 18:41 ` Yuchung Cheng
-- strict thread matches above, loose matches on Subject: below --
2018-11-26 9:35 Sharath Chandra Vurukala
2018-11-26 10:16 ` Joey Pabalinas
2018-11-28 0:15 ` David Miller
2018-11-28 0:29 ` Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20dde5c1-959e-c14b-9640-82f96e29ff76@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=chinagar@codeaurora.org \
--cc=kapandey@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=sharathv@codeaurora.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).