From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb() Date: Fri, 30 Nov 2018 10:40:39 -0800 Message-ID: <20dde5c1-959e-c14b-9640-82f96e29ff76@gmail.com> References: <20181130182828.GA27508@svurukal-linux.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: chinagar@codeaurora.org, kapandey@codeaurora.org, subashab@codeaurora.org To: Sharath Chandra Vurukala , netdev@vger.kernel.org Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:36708 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbeLAFuv (ORCPT ); Sat, 1 Dec 2018 00:50:51 -0500 Received: by mail-pg1-f196.google.com with SMTP id n2so2869741pgm.3 for ; Fri, 30 Nov 2018 10:40:40 -0800 (PST) In-Reply-To: <20181130182828.GA27508@svurukal-linux.qualcomm.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/30/2018 10:28 AM, Sharath Chandra Vurukala wrote: > when the tcp_retranmission_timer expires and tcp_retranmsit_skb is > called if the retranmsission fails due to local congestion, > backoff should not incremented. > > tcp_retransmit_skb() returns non-zero negative value in some cases of > failure but the caller tcp_retransmission_timer() has a check for > failure which checks if the return value is greater than zero. > The check is corrected to check for non-zero value. > > Signed-off-by: Sharath Chandra Vurukala > This looks wrong. Yuchung has cooked a patch series to really address issues, please wait for it We are waiting for David Miller to merge a prior patch series into net tree, then in net-next. Thanks.