From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6665C43381 for ; Tue, 26 Feb 2019 02:23:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8355221841 for ; Tue, 26 Feb 2019 02:23:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hju2pljY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726217AbfBZCXg (ORCPT ); Mon, 25 Feb 2019 21:23:36 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41523 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfBZCXg (ORCPT ); Mon, 25 Feb 2019 21:23:36 -0500 Received: by mail-pg1-f196.google.com with SMTP id m1so5423541pgq.8 for ; Mon, 25 Feb 2019 18:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/f44xhsJVsVbyjRe/ehmXS8Lw2hnWpR8w2R4rMMk9vY=; b=hju2pljYc71a8ms4QZ6967Kjy5Ncml6h0SczT1fRsAws0uaMlm4vncJVyntw43mbKb tuTJ+5MSFAOU+6dvZxLvRd7f11ypjS+UiMoVTt8+d1dETSU97nXAmRoqlSvU22HrL+oQ YLcwC370zYeir2esmnDm4InZneZ2OZsKyGyEXrMrQqjjy8oHplLhtFuKEfwYm/YLebjR v8oTrwQ93+EHmmDMAIcxm7ZFszaoSG7B9UxRJ2AIlAg2383JMfGOs5hXwoUjihxeQsbK GbQGudDuktRQYR2Ho4CKmDJ2tBtOEBXwZ5x5QhkSEZLA+rKwH3NHsWE5m7OH1sQPXeD0 TvTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/f44xhsJVsVbyjRe/ehmXS8Lw2hnWpR8w2R4rMMk9vY=; b=V4ND9TeEfE/wpAZPgNTKDhvN89v64/DShWocedgrrhcGUkvllD+g/wi9Fe+PheDaNM zkKciQvzyEANnZI4dzVlbmsMDCRAb7tuD4f2bGo+hJB/Zyfblr79gR7VGml5MvdkqaFm DGvSBVMX3zhc3Z3w7SDjJhJwoD2LWnPpjHu7dwXCathEN251GVGxPZtDuGIk6wHvgQjK HrPQJMD9UYkZLZYrQsNVHuSs1P6S56YNMsdV0WM4SaW8pYs6YpbuGIITbkJiLOhh34ar 98TpE7iJveH/Jd8v+qIlb1soB6jVnSvi2bwQhhsjNaBWmeSdYIaAonzw9TLTkDylCV71 p+bg== X-Gm-Message-State: AHQUAuaq1L3TWCrQbd039dL1D/9zY3iWjvtdFzGKuWYKWzg2QfQGYosv NZGdWESQ9q7wdIKAKCahl6L08DjB X-Google-Smtp-Source: AHgI3IZR6x3hVq1Q+jIhs15MMy40GoO+UNdTaiMklW09NTX0ODweQnIPVMbXq3UUTg7UGGqhVm58fw== X-Received: by 2002:aa7:8392:: with SMTP id u18mr7102401pfm.59.1551147815619; Mon, 25 Feb 2019 18:23:35 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:e962:5547:1520:25d4? ([2601:282:800:fd80:e962:5547:1520:25d4]) by smtp.googlemail.com with ESMTPSA id q18sm13174291pgv.9.2019.02.25.18.23.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 18:23:34 -0800 (PST) Subject: Re: [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto To: Hangbin Liu Cc: Sabrina Dubroca , netdev@vger.kernel.org, Roopa Prabhu , "David S . Miller" References: <20190225074700.7316-1-liuhangbin@gmail.com> <20190225111439.GA26565@bistromath.localdomain> <212750de-2d6a-ebb9-5079-bacf234f6cf6@gmail.com> <20190226021739.GS10051@dhcp-12-139.nay.redhat.com> From: David Ahern Message-ID: <20f3652d-479b-7be1-cf13-e7d8a61dca9e@gmail.com> Date: Mon, 25 Feb 2019 19:23:33 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190226021739.GS10051@dhcp-12-139.nay.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/25/19 7:17 PM, Hangbin Liu wrote: > I also thought about this issue. Currently we didn't check the ipproto in both > IPv4 and IPv6. You can set icmp in ip6 rules or icmpv6 in ipv4 rules. > This looks don't make any serious problem. It's just a user mis-configuration, > the kernel check the proto number and won't match normal IP/IPv6 headers. > > But yes, we should make it more strict, do you think if I should add a new > rtm_getroute_parse_ip6_proto() function, or just add a family parameter > in previous function? I see now. rtm_getroute_parse_ip_proto is used for ipv4 and ipv6. For v4 IPPROTO_ICMPV6 should not be allowed and for v6 IPPROTO_ICMP should fail. You could a version argument to rtm_getroute_parse_ip_proto and fail as needed.