Re: [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.

[Mattias Forsblad <mattias.forsblad@gmail.com>]

On 2022-09-06 14:29, Andrew Lunn wrote:
>> +int mv88e6085_g1_rmu_enable(struct mv88e6xxx_chip *chip, int upstream_port)
>> +{
>> +	int val = MV88E6352_G1_CTL2_RMU_MODE_DISABLED;
>> +
>> +	dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
>> +
>> +	switch (upstream_port) {
> 
>>  
>> +int mv88e6352_g1_rmu_enable(struct mv88e6xxx_chip *chip, int port)
>> +{
>> +	int val = MV88E6352_G1_CTL2_RMU_MODE_DISABLED;
>> +	int upstream_port;
>> +
>> +	upstream_port = dsa_switch_upstream_port(chip->ds);
>> +	dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
>> +	if (upstream_port < 0)
>> +		return -EOPNOTSUPP;
>> +
>> +	switch (upstream_port) {
> 
>> +int mv88e6390_g1_rmu_enable(struct mv88e6xxx_chip *chip, int upstream_port)
>> +{
>> +	int val = MV88E6390_G1_CTL2_RMU_MODE_DISABLED;
>> +
>> +	dev_dbg(chip->dev, "RMU: Enabling on port %d", upstream_port);
>> +
>> +	switch (upstream_port) {
> 
> 
> Why is 6352 different to 6085 and 6390? This is the sort of thing
> which should be explained in the commit message. The commit message is
> about the 'Why?' of the change. You could explain why there is this
> difference, so a reviewer does not need to ask.
> 
> 	    Andrew

I'm sorry, I must have slipped on the keyboard :/ It should be similar for
all functions. I'll fix that.

	Mattias