From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD38C433DB for ; Sun, 14 Feb 2021 01:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B36FE64E39 for ; Sun, 14 Feb 2021 01:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbhBNBSf (ORCPT ); Sat, 13 Feb 2021 20:18:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbhBNBSb (ORCPT ); Sat, 13 Feb 2021 20:18:31 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77B7EC061756 for ; Sat, 13 Feb 2021 17:17:51 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id u66so4053041oig.9 for ; Sat, 13 Feb 2021 17:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F5e/BsLBCqAAU2ayIqxHkQ9TXoLeHejuRav7SK6dtM8=; b=oqFqgovKxwwZMYJC4JiMQE2EoXhMtVAHFw0KiLJlTO3Uq9HWnhRg0loBhg8K7/eSzf bLFUIg0pX31S4VCrJR34Cvghi0d2g+P9PNu5r+EiB+29GQpXiISrFvaM2AJwpdIqAaKc BRL5sCVNgQgjK5TExnZRgXjRTsJ9MdcGuF3Ynf+zcw/HLeukDQs2utsJ/ZrajHNOHFeR aZgi2AFxFf6+Y+chZUo3JvufH1HPWWKEH6P6TWmsDN79CrMTli/yhBeJVdyvBTY+xupX 5wipBMjqp1NzG0zxlEwNaiA0s/1xtna71M5LQPNppkwrqP7tIX2EcjhEnLP0RVUKN4AP EVxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F5e/BsLBCqAAU2ayIqxHkQ9TXoLeHejuRav7SK6dtM8=; b=c2qDZ5kUMzLFNXo9XefP3A61XTt7L1Ce/a1+JwAmnvH50HR03ZvLSC2mERkkRCFCya JreHXmWRPeJhlx9MnSgGjDLw4Ih9bEuDwv/u+f4llPr143OMv+3/l5Zvc6bWwKUT6X2V WSnPknzlgK5/qJSAl16C/ru/4V625cAfXILHXHrqCQCKdll6Tfl+Qm9oIKel8S/tR7Fa FOepsHfJlAHv+e9PSfRVJJVjhXe++SYQi2tBEwXINyMN9/3jDigfJPqntN8Sv9/8w9AB lxtN03XCpf7Az4GA2o02vrpyPLQJF6DPQyMbNsexjExobK7Vh9u4BkNrm+pHtTR5Z5FZ /w9w== X-Gm-Message-State: AOAM533YFIcNDNl87fOmjz5gtdC1/ZceFFvtgfxCD/M1heexDRgRRbpQ xIOZ707BUuUbpfKuVpWraL8= X-Google-Smtp-Source: ABdhPJzNYJcdN59xw2UR5rrht3uhfz3kHvQh7uyDEUF5nIXI+2ZPt1s65dg4IZ9rMtqC963T9QTLew== X-Received: by 2002:a54:4106:: with SMTP id l6mr4385533oic.110.1613265470833; Sat, 13 Feb 2021 17:17:50 -0800 (PST) Received: from ?IPv6:2600:1700:dfe0:49f0:e93c:cbea:e191:f62a? ([2600:1700:dfe0:49f0:e93c:cbea:e191:f62a]) by smtp.gmail.com with ESMTPSA id z8sm1952893oib.36.2021.02.13.17.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Feb 2021 17:17:50 -0800 (PST) Subject: Re: [PATCH net-next 5/5] net: dsa: propagate extack to .port_vlan_filtering To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Woojung Huh , Linus Walleij , Hauke Mehrtens , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , DENG Qingfang , Ido Schimmel References: <20210213204319.1226170-1-olteanv@gmail.com> <20210213204319.1226170-6-olteanv@gmail.com> From: Florian Fainelli Message-ID: <2121afa5-72f1-a184-d06a-2314d4774a1a@gmail.com> Date: Sat, 13 Feb 2021 17:17:46 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210213204319.1226170-6-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/2021 12:43, Vladimir Oltean wrote: > From: Vladimir Oltean > > Some drivers can't dynamically change the VLAN filtering option, or > impose some restrictions, it would be nice to propagate this info > through netlink instead of printing it to a kernel log that might never > be read. Also netlink extack includes the module that emitted the > message, which means that it's easier to figure out which ones are > driver-generated errors as opposed to command misuse. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian