From: Peter Wu <peter@lekensteyn.nl>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
Ben Hutchings <ben@decadent.org.uk>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 0/6] rtlwifi: Fix incorrect MSR mask
Date: Tue, 24 Jun 2014 00:26:56 +0200 [thread overview]
Message-ID: <2124336.rxQ7Vr5PF1@al> (raw)
In-Reply-To: <1403560098-7520-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Monday 23 June 2014 23:48:16 Rickard Strandqvist wrote:
> An error was found in many rtlwifi drivers where an invalid mask was used,
> (bt_msr & 0xfc) will never match 0x3. This has been corrected by supplying
> a valid mask as a macro. Drivers which did not have this bug are still
> modified for consistency.
LGTM for all 6 patches. Reviewed-by was added with permission in a
private conversation.
> Rickard Strandqvist (1):
> rtlwifi: Fix media status register mask AND Replace magic number by macro
This looks a bit unfortunate, next time just wipe old patches and
generate new ones with git-format-patch, then use the command
git-send-email patches/*. In that way, the threading stays intact.
Kind regards,
Peter
> drivers/net/wireless/rtlwifi/rtl8188ee/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8188ee/reg.h | 1 +
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/reg.h | 1 +
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192de/reg.h | 1 +
> drivers/net/wireless/rtlwifi/rtl8723ae/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/reg.h | 1 +
> drivers/net/wireless/rtlwifi/rtl8723be/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8723be/reg.h | 1 +
> drivers/staging/rtl8821ae/rtl8821ae/hw.c | 2 +-
> drivers/staging/rtl8821ae/rtl8821ae/reg.h | 1 +
> 13 files changed, 13 insertions(+), 7 deletions(-)
prev parent reply other threads:[~2014-06-23 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 21:48 [PATCHv3 0/6] rtlwifi: Fix incorrect MSR mask Rickard Strandqvist
2014-06-23 21:48 ` [PATCHv3 1/6] rtlwifi/rtl8192de: Fix media status register mask Rickard Strandqvist
2014-06-23 22:26 ` Peter Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2124336.rxQ7Vr5PF1@al \
--to=peter@lekensteyn.nl \
--cc=Larry.Finger@lwfinger.net \
--cc=ben@decadent.org.uk \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).