[PATCH 5/5] net-next:asix: v2 update VERSION only

[PATCH 5/5] net-next:asix: v2 update VERSION only

[Grant Grundler]

Update VERSION to reflect previous changes.

Signed-off-by: Grant Grundler <grundler@chromium.org>
---
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -36,7 +36,7 @@
 #include <linux/usb/usbnet.h>
 #include <linux/slab.h>
 
-#define DRIVER_VERSION "26-Sep-2011"
+#define DRIVER_VERSION "08-Nov-2011"
 #define DRIVER_NAME "asix"
 
 /* ASIX AX8817X based USB 2.0 Ethernet Devices */

Re: [PATCH 5/5] net-next:asix: v2 update VERSION only

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said:

> -#define DRIVER_VERSION "26-Sep-2011"
> +#define DRIVER_VERSION "08-Nov-2011"

Aren't these sort of things more than a tad silly for an in-kernel driver?

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

Re: [PATCH 5/5] net-next:asix: v2 update VERSION only

[Rick Jones]

On 11/15/2011 04:29 PM, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said:
>
>> -#define DRIVER_VERSION "26-Sep-2011"
>> +#define DRIVER_VERSION "08-Nov-2011"
>
> Aren't these sort of things more than a tad silly for an in-kernel driver?

Probably depends on whether or not a distro back-ports something from 
upstream.

rick jones

Re: [PATCH 5/5] net-next:asix: v2 update VERSION only

[Grant Grundler]

On Tue, Nov 15, 2011 at 4:29 PM,  <Valdis.Kletnieks@vt.edu> wrote:
> On Mon, 14 Nov 2011 16:52:37 PST, Grant Grundler said:
>
>> -#define DRIVER_VERSION "26-Sep-2011"
>> +#define DRIVER_VERSION "08-Nov-2011"
>
> Aren't these sort of things more than a tad silly for an in-kernel driver?

Definitely not. Supporting linux device drivers essentially requires
some mechanism like this. We could use anything (SHA1, Mayan Calendar,
etc). This driver happens to use a ISO-like date code.

Upstream drivers are routinely back ported to distro releases. Version
is the primary means for a vendor (like ASIX) to determine what was
back ported. Distro maintainers and 1st tier support organizations
also need to track versions and "ethtool -i" is the canonical way to
look this up on a running system.

grant

Re: [PATCH 5/5] net-next:asix: v2 update VERSION only

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

On Tue, 15 Nov 2011 17:37:47 PST, Grant Grundler said:

> Upstream drivers are routinely back ported to distro releases. Version
> is the primary means for a vendor (like ASIX) to determine what was
> back ported. Distro maintainers and 1st tier support organizations
> also need to track versions and "ethtool -i" is the canonical way to
> look this up on a running system.

Oh, OK.  I figured the distro would know what they backported based on the
kernel version they generated - I forgot that sometimes users will bypass the
distro and go to the upstream vendor, and you may not know what their distro
had done...


[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]