From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tom Herbert <tom@herbertland.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling
Date: Sat, 16 Dec 2017 09:45:20 +0100 [thread overview]
Message-ID: <2130928.Gov3uGz9Ek@sven-edge> (raw)
In-Reply-To: <CAF=yD-LSwR3ggm5Ss4sLNx08bG8ks5TT+SvryDK5ReKtv1-dBQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote:
[....]
> Thanks for making these changes. The flow dissection looks good to me.
>
> One possible issue is that this exposes kernel fixed width types u8/u16/..
> to userspace. For posix compatibility reasons, uapi headers use the
> variant with underscores.
Thanks for the info - missed this.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-12-16 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 18:23 [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling Sven Eckelmann
2017-12-15 18:23 ` [RFC v3 1/4] batman-adv: Let packet.h include its headers directly Sven Eckelmann
[not found] ` <20171215182313.15767-1-sven.eckelmann-lv6y7wLVQPlWk0Htik3J/w@public.gmane.org>
2017-12-15 18:23 ` [RFC v3 2/4] batman-adv: Remove usage of BIT(x) in packet.h Sven Eckelmann
2017-12-15 18:23 ` [RFC v3 3/4] batman-adv: Convert packet.h to uapi header Sven Eckelmann
2017-12-15 18:23 ` [RFC v3 4/4] flow_dissector: Parse batman-adv unicast headers Sven Eckelmann
2017-12-15 22:51 ` [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling Willem de Bruijn
2017-12-16 8:45 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2130928.Gov3uGz9Ek@sven-edge \
--to=sven.eckelmann@openmesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox