From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A76C433EF for ; Wed, 22 Sep 2021 16:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3E2661181 for ; Wed, 22 Sep 2021 16:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236574AbhIVQLj (ORCPT ); Wed, 22 Sep 2021 12:11:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236568AbhIVQLh (ORCPT ); Wed, 22 Sep 2021 12:11:37 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF01EC061574 for ; Wed, 22 Sep 2021 09:10:07 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id j15so655023plh.7 for ; Wed, 22 Sep 2021 09:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6yIzAKDKHvIM1DVT8xTcKq4w3iUCl1AEsIyruztrenI=; b=nmSTPvjoSOWEniS/1shEpYAKlnc+C1lnKNHQ8w6dxX2ohQPM/g56kF/76tftfl+vMQ aDLIwb19Q0qOt9eu8pD90BlI3G/BFw34Syra9/l4Ia/hXaMoIWFQHhUOkHkxdeWfU8YJ VKOWoifbn2nQVsTnZtY10kU9PCJXat1WJ9Sz5ImxyR8il8bCrEIcjZQPlFlOQXAnk1rV NcCEh1+wYHa2uNdUBl2oJdqbYWLxiZHqAtYBlZJ8sLD3Yw6jUOYcmabxloLYpZ7X3GQp X9OfBLtRp8/Q8SYn2Qp4eiNJ8bUoClhtTxSP4B6itvq3XAu6LHPCTfaz3BLKpPCava2U NqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6yIzAKDKHvIM1DVT8xTcKq4w3iUCl1AEsIyruztrenI=; b=nNVKnzX13iM0aW+KDTFLuqfncQPa6DEHz3YGkXCvICvSYJPBOKAUgwl1J8wmeuJjuy 8N6G1MEzy4upRPS1h5Z7u1q57lDULfSMY7pTyG57LhOHYcxN6+DfJAkfuD6s12j3b9qp 5b4J9IXx9IrZyqmo2llE4HZZQB/ZP9T0QevmAXN3yycONdXhCc/Jq/OhTz8j8ajp5tnG nDJHNrtdHvUtpQwbZfFirw6WMDi/Gu+pKAn7Q4V0RnkgEOV4PBfvAgbAQV1ZtqEEZPj9 lgPz/BInnUUf6HR/kZ/9s1jRZtBzGMZsL362DhZZ11OgdJXNiR15ekO370wXDz1RqWRP UnHA== X-Gm-Message-State: AOAM532F6QKm7kR30yZVxCmMBAoevJvIVpgno2cFJIL6Ra6CknqRUrNK Umt4JE543wgmn8J9BOtXvzo= X-Google-Smtp-Source: ABdhPJx5KSedBZY6AK9HC8Q6APIApHbG0Cp9WmVpnVNO9SDugOuYLeWQSqySowLty7M6Ch+MYdX/ag== X-Received: by 2002:a17:90a:11:: with SMTP id 17mr200436pja.238.1632327007465; Wed, 22 Sep 2021 09:10:07 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id b3sm2911998pfo.23.2021.09.22.09.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 09:10:07 -0700 (PDT) Subject: Re: [PATCH net-next] net: dsa: sja1105: stop using priv->vlan_aware To: Vladimir Oltean , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski References: <20210922144401.2445527-1-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: <2132c4bb-dac0-b2c7-50b0-31a9873006e2@gmail.com> Date: Wed, 22 Sep 2021 09:10:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210922144401.2445527-1-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/22/21 7:44 AM, Vladimir Oltean wrote: > Now that the sja1105 driver is finally sane enough again to stop having > a ternary VLAN awareness state, we can remove priv->vlan_aware and query > DSA for the ds->vlan_filtering value (for SJA1105, VLAN filtering is a > global property). > > Also drop the paranoid checking that DSA calls ->port_vlan_filtering > multiple times without the VLAN awareness state changing. It doesn't, > the same check is present inside dsa_port_vlan_filtering too. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian