From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
To: ext Hemant-vilas RAMDASI <hemant.ramdasi@stericsson.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: about tx_queue_len for phonet driver
Date: Thu, 12 Jan 2012 13:56:28 +0200 [thread overview]
Message-ID: <2151675.UOkxvXJjp1@hector> (raw)
In-Reply-To: <81C3A93C17462B4BBD7E272753C105791FB10F9968@EXDCVYMBSTM005.EQ1STM.local>
Hello,
Le Jeudi 12 Janvier 2012 11:45:48 ext Hemant-vilas RAMDASI a écrit :
> Can anyone guide me about when should a network driver set tx_queue_len to
> 0? We are facing a network congestion issue with phonet packets where one
> of the control message packet is dropped because of congestion. In our
> phonet network driver the tx_queue_len is set to 3 (taken from usb-phonet
> mostly). If phonet cannot handle packet-drop (for pipe messages), then
> should network driver always set tx_queue_len as 0?
In theory, I guess the network device queuing discipline should be avoided
altogether, unless there is another way to prevent packet loss, that I am not
aware of. Unfortunately dropping qdisc, and thus net_device also, would have
major redesign implications on the Linux Phonet infrastructure to say the
least.
In any case, Phonet devices typically fail to provide sane, reliable and race-
free congestion control. I have seen some Phonet modem firmwares that just
crash if they receive too many and/or too large packets. Alas, this cannot be
fixed on the Linux / application processor side.
So you have to find a value large enough to avoid packet loss, but also small
enough to avoid overflow and who-knows-what bugs on the modem side. For the
record, the SSI driver queue length found on Nokia N9/N950 defaults to 100.
--
Rémi Denis-Courmont
http://www.remlab.net/
prev parent reply other threads:[~2012-01-12 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 10:45 about tx_queue_len for phonet driver Hemant-vilas RAMDASI
2012-01-12 10:57 ` Eric Dumazet
2012-01-12 11:24 ` Hemant-vilas RAMDASI
2012-01-12 11:56 ` Rémi Denis-Courmont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2151675.UOkxvXJjp1@hector \
--to=remi.denis-courmont@nokia.com \
--cc=hemant.ramdasi@stericsson.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox