From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Vosburgh Subject: Re: [PATCH net-next v2 2/5] bonding: fix bond_open() don't always set slave active flag Date: Mon, 26 Jan 2015 16:33:24 -0800 Message-ID: <21599.1422318804@famine> References: <1422253021-3798-1-git-send-email-jtoppins@cumulusnetworks.com> <1422253021-3798-3-git-send-email-jtoppins@cumulusnetworks.com> Cc: Veaceslav Falico , Andy Gospodarek , netdev@vger.kernel.org, Wilson Kok , Andy Gospodarek To: Jonathan Toppins Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:60074 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757451AbbA0Ad2 (ORCPT ); Mon, 26 Jan 2015 19:33:28 -0500 In-reply-to: <1422253021-3798-3-git-send-email-jtoppins@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: Jonathan Toppins wrote: >From: Wilson Kok > >Mode 802.3ad, fix incorrect bond slave active state when slave is not in >active aggregator. During bond_open(), the bonding driver always sets >the slave active flag to true if the bond is not in active-backup, alb, >or tlb modes. Bonding should let the aggregator selection logic set the >active flag when in 802.3ad mode. > >Cc: Andy Gospodarek >Reviewed-by: Nikolay Aleksandrov >Signed-off-by: Wilson Kok >Signed-off-by: Jonathan Toppins Signed-off-by: Jay Vosburgh >--- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index 02ffedb..c475d90 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -3066,7 +3066,7 @@ static int bond_open(struct net_device *bond_dev) > slave != rcu_access_pointer(bond->curr_active_slave)) { > bond_set_slave_inactive_flags(slave, > BOND_SLAVE_NOTIFY_NOW); >- } else { >+ } else if (BOND_MODE(bond) != BOND_MODE_8023AD) { > bond_set_slave_active_flags(slave, > BOND_SLAVE_NOTIFY_NOW); > } >-- >1.7.10.4 >