From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yoann P." Subject: Re: [PATCH] Fix ss Netid column and Local/Peer_Address Date: Mon, 29 Oct 2018 23:20:42 +0100 Message-ID: <2166691.rlxvmHoyJL@yo-gs> References: <5185850.l7bAsbzJZX@yo-gs> <2356588.cRoqrM3dbm@yo-gs> <20181029230307.12919fb6@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, Stephen Hemminger To: Stefano Brivio Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:41054 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbeJ3HLZ (ORCPT ); Tue, 30 Oct 2018 03:11:25 -0400 Received: by mail-wr1-f67.google.com with SMTP id x12-v6so10405019wrw.8 for ; Mon, 29 Oct 2018 15:20:44 -0700 (PDT) In-Reply-To: <20181029230307.12919fb6@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Le lundi 29 octobre 2018, 23:03:07 CET Stefano Brivio a =E9crit : > On Mon, 29 Oct 2018 21:06:35 +0100 >=20 > "Yoann P." wrote: > > > By the way, why do you use column(1), when ss already prints output in > > > columns? Any other issue you are working around? > >=20 > > column can hide columns with "-H -" and is a bit faster than awk to out= put > > a single column according to time, it's the only reason I mentioned it. > Okay, but why do you need to hide some columns in the first place? I'm > wondering if your use case would justify adding options to print > selected columns only, in a generic way (right now, you can only > disable some). >=20 > Another possibility would be to rename "Local Address:" to "Local:" and > "Peer Address:" to "Peer:" -- in some cases (UNIX sockets) it's already > not so much of an address, more of a path, and "Address" doesn't really > add value when the field contains an address. >=20 > I don't like too much "Local_Address:" and "Peer_Address:" as the > output is supposed to be human-readable by default, and that underscore > just doesn't fit. I send the peer address column to geoiplookup (currently changing to=20 mmdblookup as geoip database is replaced by geolite2) to recover Country,=20 Asnum and ASname of peers.