From: Jay Vosburgh <fubar@us.ibm.com>
To: monis@voltaire.com
Cc: netdev <netdev@vger.kernel.org>, Olga Stern <olgas@voltaire.com>,
Or Gerlitz <ogerlitz@voltaire.com>
Subject: Re: [PATCH]: net/bonding: Enable to change device type before enslaving
Date: Thu, 10 Apr 2008 13:48:24 -0700 [thread overview]
Message-ID: <21771.1207860504@death> (raw)
In-Reply-To: <47FE2DBF.7080803@voltaire.com>
Moni Shoua <monis@voltaire.com> wrote:
>
>The bonding network device is being created with device type ARPHDR_ETHER.
>Although the device type changes with first slave we want to be able to change
>it when it has zero slaves. The reason is to make the kernel choose the right
>function for multicast address translation (ib_xxx_mc_map) which is determined by
>device type even when no slaves are enslaved. If not so, the kernel picks a wrong
>translation function and wrong HW addresses will be passed to slaves when the
>bonding device tries to set their multicast lists.
Does this mean that the automatic selection on first enslavement
is no longer needed, and all setting of the type for IB devices must
occur prior to first enslavement?
Or is this more of a special case for some devices, and the
automatic selection is still correct for most cases?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2008-04-10 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 15:09 [PATCH]: net/bonding: Enable to change device type before enslaving Moni Shoua
2008-04-10 20:48 ` Jay Vosburgh [this message]
2008-04-13 14:09 ` Moni Shoua
2008-04-16 19:27 ` Jay Vosburgh
2008-04-17 6:29 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21771.1207860504@death \
--to=fubar@us.ibm.com \
--cc=monis@voltaire.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=olgas@voltaire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).