From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: bhelgaas@google.com, davem@davemloft.net,
netanel@annapurnalabs.com, jcliburn@gmail.com,
chris.snook@gmail.com, sgoutham@cavium.com, rric@kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 5/5] PCI: remove pci_enable_msix
Date: Tue, 28 Mar 2017 09:24:15 -0700 [thread overview]
Message-ID: <217ae0b0-1d0c-bde9-e3f1-c52cbd3bd112@gmail.com> (raw)
In-Reply-To: <20170328064148.GA20271@lst.de>
On 03/27/2017 11:41 PM, Christoph Hellwig wrote:
> On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote:
>>> Use pci_enable_msix_{exact,range} for now, as I told you before.
>>>
>>
>> That still results in twice as many MSI-X being provisioned than are needed.
>
> How so? Except for the return value, a pci_enable_msix_exact call with the
> same arguments as your previous pci_enable_msix will work exactly the
> same.
>
Sorry, I think it was my misunderstanding. I didn't realize that we had
essentially renamed the function, but left the functionality mostly
unchanged.
next prev parent reply other threads:[~2017-03-28 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 8:29 remove pci_enable_msix() Christoph Hellwig
2017-03-27 8:29 ` [PATCH 1/5] net: thunderx: switch to pci_alloc_irq_vectors Christoph Hellwig
2017-03-27 16:03 ` Sunil Kovvuri
2017-03-27 17:12 ` Christoph Hellwig
2017-03-27 8:29 ` [PATCH 2/5] net: thunderxvf: " Christoph Hellwig
2017-03-27 8:29 ` [PATCH 3/5] net: alx: " Christoph Hellwig
2017-03-27 8:29 ` [PATCH 4/5] net/ena: " Christoph Hellwig
2017-03-27 8:29 ` [PATCH 5/5] PCI: remove pci_enable_msix Christoph Hellwig
2017-03-27 14:06 ` David Laight
2017-03-27 14:51 ` 'Christoph Hellwig'
2017-03-27 15:03 ` David Laight
2017-03-27 17:10 ` 'Christoph Hellwig'
2017-03-27 16:59 ` David Daney
2017-03-27 17:11 ` Christoph Hellwig
2017-03-27 17:30 ` David Daney
2017-03-28 6:41 ` Christoph Hellwig
2017-03-28 16:24 ` David Daney [this message]
2017-03-30 22:56 ` Bjorn Helgaas
2017-03-30 23:00 ` David Daney
2017-03-28 9:07 ` David Laight
2017-03-30 23:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=217ae0b0-1d0c-bde9-e3f1-c52cbd3bd112@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=bhelgaas@google.com \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=jcliburn@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).