* nfs+tcp boot failures on linuxnext-20180924 from switch tcp_clock_ns to CLOCK_TAI
@ 2018-09-27 1:15 Leonard Crestez
2018-09-27 2:18 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Leonard Crestez @ 2018-09-27 1:15 UTC (permalink / raw)
To: sfr@canb.auug.org.au, davem@davemloft.net, edumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Hello,
It seems that after commit 72b0094f9182 ("tcp: switch tcp_clock_ns() to
CLOCK_TAI base") some systems that use nfs over tcp fail to boot. The
last line printed in the log is from systemd:
[ 7.232579] systemd[1]: System time before build time, advancing clock.
Superficially it looks like very large clock discontinuities now break
TCP. Maybe boottime could avoid such issues?
I didn't find similar reports anywhere else. The machines I’m seeing
this are all 32bit arm imx (this shouldn’t matter) and it seems their
RTC isn’t properly setup so they boot with realtime set to unix zero,
then a ~50 years jump happens when systemd starts up. This is the
likely trigger for this issue.
--
Regards,
Leonard
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: nfs+tcp boot failures on linuxnext-20180924 from switch tcp_clock_ns to CLOCK_TAI
2018-09-27 1:15 nfs+tcp boot failures on linuxnext-20180924 from switch tcp_clock_ns to CLOCK_TAI Leonard Crestez
@ 2018-09-27 2:18 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2018-09-27 2:18 UTC (permalink / raw)
To: Leonard Crestez, sfr@canb.auug.org.au, davem@davemloft.net,
edumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, Jesus Sanchez-Palencia,
Vinicius Costa Gomes
On 09/26/2018 06:15 PM, Leonard Crestez wrote:
> Hello,
>
> It seems that after commit 72b0094f9182 ("tcp: switch tcp_clock_ns() to
> CLOCK_TAI base") some systems that use nfs over tcp fail to boot. The
> last line printed in the log is from systemd:
>
> [ 7.232579] systemd[1]: System time before build time, advancing clock.
>
> Superficially it looks like very large clock discontinuities now break
> TCP. Maybe boottime could avoid such issues?
>
> I didn't find similar reports anywhere else. The machines I’m seeing
> this are all 32bit arm imx (this shouldn’t matter) and it seems their
> RTC isn’t properly setup so they boot with realtime set to unix zero,
> then a ~50 years jump happens when systemd starts up. This is the
> likely trigger for this issue.
>
Thanks for the report.
It is annoying, because SCM_TXTIME and net/sched/sch_etf.c are using CLOCK_TAI,
so it means that if we convert TCP (and net/sched/sch_fq.c) back to ktime_get_ns(),
we will have to differentiate in skbs the clock base.
This has been discussed in the past (When ETF was merged in 4.19) and we chose
to use a common clock base.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-27 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-27 1:15 nfs+tcp boot failures on linuxnext-20180924 from switch tcp_clock_ns to CLOCK_TAI Leonard Crestez
2018-09-27 2:18 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).