From: Oliver Neukum <oneukum@suse.de>
To: Steve Glendinning <steve.glendinning@shawell.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: ratelimit kevent may have been dropped warnings
Date: Mon, 12 Nov 2012 08:16:29 +0100 [thread overview]
Message-ID: <2192335.eVEjctQSPm@linux-lqwf.site> (raw)
In-Reply-To: <1352391981-15692-1-git-send-email-steve.glendinning@shawell.net>
On Thursday 08 November 2012 16:26:21 Steve Glendinning wrote:
> There's an underlying problem in usbnet's kevent deferral
This is imported from schedule_work().
> mechanism which needs fixing, specifically that events *can*
> get dropped and not handled. This patch doesn't address this,
> but just mitigates fallout caused by the current implemention.
All is not lost, as the flag is still set. How about starting a timer
in the failure case? It feels kind of dirty, but a solution with locks would
leave open a window to a race in any case.
Regards
Oliver
prev parent reply other threads:[~2012-11-12 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 16:26 [PATCH] usbnet: ratelimit kevent may have been dropped warnings Steve Glendinning
2012-11-09 22:00 ` David Miller
2012-11-12 7:11 ` Oliver Neukum
2012-11-12 7:16 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2192335.eVEjctQSPm@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).