From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Justin Chen <justin.chen@broadcom.com>, netdev@vger.kernel.org
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jon Mason <jon.mason@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net: phy: broadcom: stub c45 read/write for 54810
Date: Sun, 13 Aug 2023 07:58:43 -0700 [thread overview]
Message-ID: <21a9cd2d-3c9c-dd2c-c86a-b1099c61f6fd@broadcom.com> (raw)
In-Reply-To: <1691901708-28650-1-git-send-email-justin.chen@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On 8/12/2023 9:41 PM, Justin Chen wrote:
> The 54810 does not support c45. The mmd_phy_indirect accesses return
> arbirtary values leading to odd behavior like saying it supports EEE
> when it doesn't. We also see that reading/writing these non-existent
> MMD registers leads to phy instability in some cases.
>
> Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-08-13 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 4:41 [PATCH net v2] net: phy: broadcom: stub c45 read/write for 54810 Justin Chen
2023-08-13 14:58 ` Florian Fainelli [this message]
2023-08-16 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a9cd2d-3c9c-dd2c-c86a-b1099c61f6fd@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jon.mason@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).