From: Markus Elfring <Markus.Elfring@web.de>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
kernel-janitors@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Simon Horman" <horms@kernel.org>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>
Subject: Re: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly
Date: Mon, 30 Sep 2024 13:30:16 +0200 [thread overview]
Message-ID: <21be0ed9-7b72-42fb-a2fb-b655a7ebc072@web.de> (raw)
In-Reply-To: <20240926134347.19371-1-przemyslaw.kitszel@intel.com>
…
> Current scoped_guard() implementation does not support that,
> due to compiler complaining:
…
> +++ b/include/linux/cleanup.h
> @@ -168,9 +168,16 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
>
> #define __guard_ptr(_name) class_##_name##_lock_ptr
>
> -#define scoped_guard(_name, args...) \
> - for (CLASS(_name, scope)(args), \
> - *done = NULL; __guard_ptr(_name)(&scope) && !done; done = (void *)1)
> +#define scoped_guard(_name, args...) \
> + __scoped_guard_labeled(__UNIQUE_ID(label), _name, args)
> +
> +#define __scoped_guard_labeled(_label, _name, args...) \
> + if (0) \
> + _label: ; \
> + else \
> + for (CLASS(_name, scope)(args); \
> + __guard_ptr(_name)(&scope), 1; \
> + ({ goto _label; }))
>
> #define scoped_cond_guard(_name, _fail, args...) \
> for (CLASS(_name, scope)(args), \
* How do you think about to define such macros before their use?
* Would you ever like to avoid reserved identifiers in such source code?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus
next prev parent reply other threads:[~2024-09-30 11:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 13:41 [RFC PATCH] cleanup: make scoped_guard() to be return-friendly Przemek Kitszel
2024-09-27 7:31 ` Dan Carpenter
2024-09-27 14:08 ` Przemek Kitszel
2024-09-27 15:04 ` Dan Carpenter
2024-09-30 10:21 ` Przemek Kitszel
2024-09-30 11:08 ` Dan Carpenter
2024-09-30 11:30 ` Przemek Kitszel
2024-09-30 12:57 ` Dan Carpenter
2024-09-30 13:07 ` Dmitry Torokhov
2024-09-30 12:57 ` Dmitry Torokhov
2024-09-30 11:30 ` Markus Elfring [this message]
2024-09-30 12:33 ` Przemek Kitszel
2024-09-30 12:51 ` [RFC] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21be0ed9-7b72-42fb-a2fb-b655a7ebc072@web.de \
--to=markus.elfring@web.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).