[PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Chukun Pan]

Some 5G WWAN modems have multiple gpio controls. When using rfkill command
to manage it, we need to at least change the status of reset and shutdown
gpios at the same time. Also, it might be incorrect to put the reset gpio
at usb when the module is connected via USB M2 slot, there may be other
devices connected under some USB node, but the reset gpio is only used for
the WWAN module. So document the reset-gpios to rfkill-gpio as an optional
property and add it to a new example.

For example:
  - reset: modem Reset#
  - shutdown: modem WWAN_DISABLE# or FULL_CARD_POWER_OFF#

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../devicetree/bindings/net/rfkill-gpio.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
index 9630c8466fac..7f297efdc976 100644
--- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
+++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
@@ -29,6 +29,9 @@ properties:
       - wlan
       - wwan
 
+  reset-gpios:
+    maxItems: 1
+
   shutdown-gpios:
     maxItems: 1
 
@@ -49,3 +52,14 @@ examples:
         radio-type = "wlan";
         shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
     };
+
+  - | # 5G WWAN modem
+    #include <dt-bindings/gpio/gpio.h>
+
+    rfkill {
+        compatible = "rfkill-gpio";
+        label = "rfkill-modem";
+        radio-type = "wwan";
+        reset-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
+        shutdown-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
+    };
-- 
2.25.1

[PATCH v2 0/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Chukun Pan]

Changes in v2:
  Update commit message.
  Add new example for WWAN modem.

-- 
2.25.1

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Krzysztof Kozlowski]

On 28/05/2024 16:30, Chukun Pan wrote:
> Some 5G WWAN modems have multiple gpio controls. When using rfkill command

Which ones? Can we see the dastasheet or schematics? People claim
various things (like device reset-gpios being part of controller...).

> to manage it, we need to at least change the status of reset and shutdown
> gpios at the same time. Also, it might be incorrect to put the reset gpio
> at usb when the module is connected via USB M2 slot, there may be other
> devices connected under some USB node, but the reset gpio is only used for
> the WWAN module. So document the reset-gpios to rfkill-gpio as an optional
> property and add it to a new example.
> 
> For example:
>   - reset: modem Reset#


Best regards,
Krzysztof

Re: [PATCH v2 0/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Krzysztof Kozlowski]

On 28/05/2024 16:35, Chukun Pan wrote:
> Changes in v2:
>   Update commit message.
>   Add new example for WWAN modem.
> 


??? Changelog goes to --- section.

Best regards,
Krzysztof

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Chukun Pan]

> Which ones? Can we see the dastasheet or schematics? People claim
> various things (like device reset-gpios being part of controller...).

Unfortunately I didn't find a public datasheet. This is a screenshot of
the GosunCn GM800 datasheet: https://imgur.com/a/4ecCGiy

Thanks,
Chukun

-- 
2.25.1

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Krzysztof Kozlowski]

On 28/05/2024 16:52, Chukun Pan wrote:
>> Which ones? Can we see the dastasheet or schematics? People claim
>> various things (like device reset-gpios being part of controller...).
> 
> Unfortunately I didn't find a public datasheet. This is a screenshot of
> the GosunCn GM800 datasheet: https://imgur.com/a/4ecCGiy
> 

Thanks. I am asking because you might be hiding behind rfkill something
which is a PCI or USB property... anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Shengyu Qu]

[-- Attachment #1.1.1: Type: text/plain, Size: 1931 bytes --]

Hello,

What is blocking this patch to get merged? I'm seeing more 5G modules 
need this to work correctly, for example, FM350.

Best regards,
Shengyu

在 2024/5/28 22:30, Chukun Pan 写道:
> Some 5G WWAN modems have multiple gpio controls. When using rfkill command
> to manage it, we need to at least change the status of reset and shutdown
> gpios at the same time. Also, it might be incorrect to put the reset gpio
> at usb when the module is connected via USB M2 slot, there may be other
> devices connected under some USB node, but the reset gpio is only used for
> the WWAN module. So document the reset-gpios to rfkill-gpio as an optional
> property and add it to a new example.
> 
> For example:
>    - reset: modem Reset#
>    - shutdown: modem WWAN_DISABLE# or FULL_CARD_POWER_OFF#
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   .../devicetree/bindings/net/rfkill-gpio.yaml       | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..7f297efdc976 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -29,6 +29,9 @@ properties:
>         - wlan
>         - wwan
>   
> +  reset-gpios:
> +    maxItems: 1
> +
>     shutdown-gpios:
>       maxItems: 1
>   
> @@ -49,3 +52,14 @@ examples:
>           radio-type = "wlan";
>           shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
>       };
> +
> +  - | # 5G WWAN modem
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    rfkill {
> +        compatible = "rfkill-gpio";
> +        label = "rfkill-modem";
> +        radio-type = "wwan";
> +        reset-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
> +        shutdown-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> +    };


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Johannes Berg]

On Fri, 2025-07-11 at 12:37 +0800, Shengyu Qu wrote:
> Hello,
> 
> What is blocking this patch to get merged? I'm seeing more 5G modules 
> need this to work correctly, for example, FM350.
> 

I guess I have no idea, fell through the cracks and so far nobody cared
enough?

DT folks, what tree should this kind of patch go through? I guess I can
take it through wireless-next with other rfkill changes? Or should it go
through some DT tree?

johannes

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Chukun Pan]

Hi Shengyu,

> What is blocking this patch to get merged? I'm seeing more 5G modules
> need this to work correctly, for example, FM350.

I don't know either. I sent this patch again this year, [1]
but no one responded.

[1] https://lore.kernel.org/all/20250208102009.514525-2-amadeus@jmu.edu.cn/

Thanks,
Chukun

--
2.25.1

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Shengyu Qu]

[-- Attachment #1.1.1: Type: text/plain, Size: 676 bytes --]

Hi Johannes,

Since this patch is already reviewed, maybe you could just merge the v3 
if nobody replies?

Best regards,
Shengyu

在 2025/7/11 15:14, Johannes Berg 写道:
> On Fri, 2025-07-11 at 12:37 +0800, Shengyu Qu wrote:
>> Hello,
>>
>> What is blocking this patch to get merged? I'm seeing more 5G modules
>> need this to work correctly, for example, FM350.
>>
> 
> I guess I have no idea, fell through the cracks and so far nobody cared
> enough?
> 
> DT folks, what tree should this kind of patch go through? I guess I can
> take it through wireless-next with other rfkill changes? Or should it go
> through some DT tree?
> 
> johannes
> 


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Krzysztof Kozlowski]

On 11/07/2025 09:14, Johannes Berg wrote:
> On Fri, 2025-07-11 at 12:37 +0800, Shengyu Qu wrote:
>> Hello,
>>
>> What is blocking this patch to get merged? I'm seeing more 5G modules 
>> need this to work correctly, for example, FM350.
>>
> 
> I guess I have no idea, fell through the cracks and so far nobody cared
> enough?
> 
> DT folks, what tree should this kind of patch go through? I guess I can
> take it through wireless-next with other rfkill changes? Or should it go
> through some DT tree?


Preferably: net-next, wireless-next.

If you want it via DT, someone needs to explicitly ping Rob on IRC.

Best regards,
Krzysztof

Re: [PATCH v2 1/1] dt-bindings: net: rfkill-gpio: document reset-gpios

[Shengyu Qu]

[-- Attachment #1.1.1: Type: text/plain, Size: 2009 bytes --]

Hi everyone,

I have an extra question, what needs to be done if we want to support 
more than one WWAN module? There are some boards that can plug multiple 
WWAN modules, for example Banana Pi R4/R4 Pro.

Best regards,
Shengyu

在 2024/5/28 22:30, Chukun Pan 写道:
> Some 5G WWAN modems have multiple gpio controls. When using rfkill command
> to manage it, we need to at least change the status of reset and shutdown
> gpios at the same time. Also, it might be incorrect to put the reset gpio
> at usb when the module is connected via USB M2 slot, there may be other
> devices connected under some USB node, but the reset gpio is only used for
> the WWAN module. So document the reset-gpios to rfkill-gpio as an optional
> property and add it to a new example.
> 
> For example:
>    - reset: modem Reset#
>    - shutdown: modem WWAN_DISABLE# or FULL_CARD_POWER_OFF#
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   .../devicetree/bindings/net/rfkill-gpio.yaml       | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..7f297efdc976 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -29,6 +29,9 @@ properties:
>         - wlan
>         - wwan
>   
> +  reset-gpios:
> +    maxItems: 1
> +
>     shutdown-gpios:
>       maxItems: 1
>   
> @@ -49,3 +52,14 @@ examples:
>           radio-type = "wlan";
>           shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
>       };
> +
> +  - | # 5G WWAN modem
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    rfkill {
> +        compatible = "rfkill-gpio";
> +        label = "rfkill-modem";
> +        radio-type = "wwan";
> +        reset-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>;
> +        shutdown-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> +    };


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]