netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Lahav Schlesinger <lschlesinger@drivenets.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net-next v3] rtnetlink: Support fine-grained netdevice bulk deletion
Date: Mon, 29 Nov 2021 08:30:16 -0700	[thread overview]
Message-ID: <21da13fb-e629-0d6e-1aa1-56e2eb86d1c3@gmail.com> (raw)
In-Reply-To: <20211129135307.mxtfw6j7v4hdex4f@kgollan-pc>

On 11/29/21 6:53 AM, Lahav Schlesinger wrote:
> Hi David, while I also don't have any strong preference here, my
> reasoning for failing the whole request if one device can't be deleted
> was so it will share the behaviour we currently have with group deletion.
> If you're okay with this asymmetry I'll send a V4.

good point - new features should be consistent with existing code.

You can add another attribute to the request to say 'Skip devices that
can not be deleted'.

  reply	other threads:[~2021-11-29 19:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 16:51 [PATCH net-next v3] rtnetlink: Support fine-grained netdevice bulk deletion Lahav Schlesinger
2021-11-28  7:33 ` Leon Romanovsky
2021-11-28 11:13   ` Lahav Schlesinger
2021-11-28 11:43     ` Leon Romanovsky
2021-11-28 19:17       ` David Ahern
2021-11-29 13:53         ` Lahav Schlesinger
2021-11-29 15:30           ` David Ahern [this message]
2021-11-29 18:10             ` Jakub Kicinski
2021-11-29 19:14               ` David Ahern
2021-11-30  8:04               ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21da13fb-e629-0d6e-1aa1-56e2eb86d1c3@gmail.com \
    --to=dsahern@gmail.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=lschlesinger@drivenets.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).