From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH 2/5] brcmfmac: Use common CORDIC_FLOAT macro from lib Date: Mon, 5 Nov 2018 10:13:47 +0100 Message-ID: <21e6a75b-7728-761d-d899-395864226fb5@broadcom.com> References: <4bd6e7758bc0d88b33cdb09448633bb5b97aba7c.1541238842.git-series.plaes@plaes.org> <877ehrhp21.fsf@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kalle Valo , Priit Laes Return-path: In-Reply-To: <877ehrhp21.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 11/5/2018 10:05 AM, Kalle Valo wrote: > Priit Laes writes: > >> Now that cordic library has the CORDIC_FLOAT macro, use that >> >> Signed-off-by: Priit Laes >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 ++-- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++-- > > The driver is "brcmsmac" (note the 's', not 'f'), you should fix the > title accordingly. > >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c >> @@ -3447,8 +3447,8 @@ wlc_lcnphy_start_tx_tone(struct brcms_phy *pi, s32 f_kHz, u16 max_val, >> >> theta += rot; >> >> - i_samp = (u16) (FLOAT(tone_samp.i * max_val) & 0x3ff); >> - q_samp = (u16) (FLOAT(tone_samp.q * max_val) & 0x3ff); >> + i_samp = (u16)(CORDIC_FLOAT(tone_samp.i * max_val) & 0x3ff); >> + q_samp = (u16)(CORDIC_FLOAT(tone_samp.q * max_val) & 0x3ff); > > I haven't seen the patch 1 yet, but just from seeing this patch I don't > get what's the benefit. The FLOAT macro was defined in brcmsmac (see patch 3). It is now moved to the cordic library simply because it is more closely related to that. Regards, Arend