From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2071C43461 for ; Thu, 1 Apr 2021 10:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C32F3610C7 for ; Thu, 1 Apr 2021 10:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233989AbhDAKHX (ORCPT ); Thu, 1 Apr 2021 06:07:23 -0400 Received: from mxout70.expurgate.net ([194.37.255.70]:51295 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234004AbhDAKHD (ORCPT ); Thu, 1 Apr 2021 06:07:03 -0400 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.90) (envelope-from ) id 1lRuDp-0005br-Lw; Thu, 01 Apr 2021 12:06:41 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90) (envelope-from ) id 1lRuDo-000Ffc-EW; Thu, 01 Apr 2021 12:06:40 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id D96B0240041; Thu, 1 Apr 2021 12:06:39 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 44BAB240040; Thu, 1 Apr 2021 12:06:39 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id BB94C20072; Thu, 1 Apr 2021 12:06:38 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Apr 2021 12:06:38 +0200 From: Martin Schiller To: Xie He Cc: "David S. Miller" , Jakub Kicinski , Jonathan Corbet , Krzysztof Halasa , Linux X25 , Linux Kernel Network Developers , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH net-next v4] net: x25: Queue received packets in the drivers instead of per-CPU queues Organization: TDT AG In-Reply-To: References: <20210328221205.726511-1-xie.he.0141@gmail.com> Message-ID: <21ec9eafa230f2e20dd88d31fd95faa0@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.16 X-purgate-type: clean X-purgate-ID: 151534::1617271601-0000718E-4D93F7FF/0/0 X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021-03-31 20:41, Xie He wrote: > Hi Martin, > > Could you ack this patch again? The only change from the RFC version > (that you previously acked) is the addition of the "__GFP_NOMEMALLOC" > flag in "dev_alloc_skb". This is because I want to prevent pfmemalloc > skbs (which can't be handled by netif_receive_skb_core) from > occurring. > > Thanks! Hi! Sorry for my late answer. Can you please also fix this line length warning? https://patchwork.hopto.org/static/nipa/442445/12117801/checkpatch/stdout - Martin