netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wojciech Drewek <wojciech.drewek@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"simon.horman@corigine.com" <simon.horman@corigine.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH iwl-next] ice: Implement ethtool reset support
Date: Wed, 31 Jul 2024 14:08:20 +0200	[thread overview]
Message-ID: <21ed191b-2814-49bb-8722-413f62fbc938@intel.com> (raw)
In-Reply-To: <20240730065835.191bd1de@kernel.org>



On 30.07.2024 15:58, Jakub Kicinski wrote:
> On Tue, 30 Jul 2024 12:51:21 +0200 Wojciech Drewek wrote:
>> ETH_RESET_MAC - ICE_RESET_CORER
> 
> Core doesn't really sound like MAC, what is it?
> And does PF reset reset mostly PCIe side or more?
> My knee jerk mapping would be to map Core to dedicated
> and PF to DMA.
> 

Quick summary our reset types:
PF reset reinitialize the resources/data path for PF and its VFs.
It has no impact on other PF/VFs.
Core Reset reinitialize all functions and shared parts of the
device except PHY/MAC units, EMP and PCI Interface.
Global Reset is Core Reset + PHY/MAC units reset (including External PHY)
Because Global Reset is a extended Core it makes sense to map it to all.
PF reset mapping makes sense to me since it is dedicated to a single physical function.



  reply	other threads:[~2024-07-31 12:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 10:51 [PATCH iwl-next] ice: Implement ethtool reset support Wojciech Drewek
2024-07-30 13:58 ` Jakub Kicinski
2024-07-31 12:08   ` Wojciech Drewek [this message]
2024-07-31 16:48   ` [Intel-wired-lan] " Jacob Keller
2024-07-31 23:47     ` Jakub Kicinski
2024-08-01 11:01       ` Wojciech Drewek
2024-08-01 14:13         ` Jakub Kicinski
2024-07-31  8:22 ` Przemek Kitszel
2024-07-31 12:14   ` Wojciech Drewek
2024-07-31  9:24 ` Simon Horman
2024-07-31 12:11   ` Wojciech Drewek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21ed191b-2814-49bb-8722-413f62fbc938@intel.com \
    --to=wojciech.drewek@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).