From: Tom St Denis <tstdenis@elliptictech.com>
To: David Miller <davem@davemloft.net>
Cc: steffen klassert <steffen.klassert@secunet.com>,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: IPsec AH use of ahash
Date: Fri, 18 Jan 2013 15:53:44 -0500 (EST) [thread overview]
Message-ID: <220318679.90938.1358542424387.JavaMail.root@elliptictech.com> (raw)
In-Reply-To: <20130118.145005.156366015893075594.davem@davemloft.net>
----- Original Message -----
> From: "David Miller" <davem@davemloft.net>
> To: tstdenis@elliptictech.com
> Cc: "steffen klassert" <steffen.klassert@secunet.com>, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
> netdev@vger.kernel.org
> Sent: Friday, 18 January, 2013 2:50:05 PM
> Subject: Re: IPsec AH use of ahash
>
> From: Tom St Denis <tstdenis@elliptictech.com>
> Date: Fri, 18 Jan 2013 14:35:33 -0500 (EST)
>
> > Any "maintainers" going to reply to this at all?
>
> What do you mean? There was a reply, and the reply if someone
> so skilled finds this facility useful they can feel free to
> submit an implementation.
>
> You can't force people to work on something they have no interest
> in, especially when it's effectively a new feature.
>
Admittedly I'm new to the kernel scene but what exactly is a "maintainer" then?
Suppose I invest time to re-write the IPv4/v6 AH code to correctly use AEAD instead of ahash, to then perform the testing required, etc... do I get credit as a maintainer in the IPsec tree?
I'm also a little annoyed that my CMAC patch was rejected for among other reasons that it violated "coding standards." Specially since it was almost entirely copied from crypto/xcbc.c which also violates the same rules. As a newcomer to the tree I tried my best by emulating readily available code (which apparently was already accepted into the tree) to then just get shot down for attempting to contribute. If my CMAC code is not good enough for the tree I humbly suggest you also remove the XCBC code too while we're at it.
What I would expect from the "maintainers" is that they actually take on a more than trivial involvement in the progress of the code. If I have to create original content and massage it into whatever form pleases the owners of the tree am I not the maintainer of the code? I was honestly expecting someone with more involvement in the tree to move the [in this case] CMAC patch forward.
As for the AH side if it's the implied intent of the maintainers to not support all relevant [and ideally low hanging fruit] standards as possible this should be stated explicitly.
Tom
next prev parent reply other threads:[~2013-01-18 20:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528051367.70594.1358268708738.JavaMail.root@elliptictech.com>
2013-01-16 6:21 ` IPsec AH use of ahash Steffen Klassert
2013-01-18 19:35 ` Tom St Denis
2013-01-18 19:50 ` David Miller
2013-01-18 20:53 ` Tom St Denis [this message]
2013-01-18 22:16 ` Waskiewicz Jr, Peter P
2013-01-18 22:31 ` Tom St Denis
2013-01-19 2:33 ` Michal Kubecek
2013-01-19 2:59 ` Tom St Denis
2013-01-19 3:59 ` Eric Dumazet
2013-01-19 10:30 ` Tom St Denis
2013-01-19 15:46 ` Eric Dumazet
2013-01-20 5:06 ` Mike Galbraith
2013-01-20 10:31 ` Borislav Petkov
2013-01-20 12:56 ` Tom St Denis
2013-01-20 13:34 ` Alexander Holler
2013-01-20 13:54 ` Tom St Denis
2013-01-30 22:16 ` Jan Engelhardt
2013-01-20 22:07 ` Steven Rostedt
2013-01-21 0:47 ` Tom St Denis
2013-01-20 12:55 ` Tom St Denis
2013-01-20 14:11 ` Mike Galbraith
2013-01-20 15:07 ` Tom St Denis
2013-01-20 16:34 ` David Dillow
2013-01-20 17:40 ` Tom St Denis
2013-01-20 18:11 ` David Dillow
2013-01-20 18:47 ` Tom St Denis
2013-01-20 22:54 ` Steven Rostedt
2013-01-21 0:34 ` Borislav Petkov
2013-01-21 0:40 ` Tom St Denis
2013-01-21 1:08 ` Borislav Petkov
2013-01-21 9:18 ` David Dillow
2013-01-21 10:20 ` Tom St Denis
2013-01-21 13:38 ` Steven Rostedt
2013-01-21 13:45 ` Tom St Denis
2013-01-21 14:37 ` Steven Rostedt
2013-01-21 14:51 ` Tom St Denis
2013-01-21 15:28 ` Steven Rostedt
2013-01-21 15:31 ` Tom St Denis
2013-01-21 15:49 ` Chris Friesen
2013-01-21 16:05 ` Tom St Denis
2013-01-20 20:30 ` Alan Cox
2013-01-21 0:46 ` Tom St Denis
2013-01-20 17:03 ` H. Peter Anvin
2013-01-20 17:33 ` Tom St Denis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220318679.90938.1358542424387.JavaMail.root@elliptictech.com \
--to=tstdenis@elliptictech.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).